From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] eal: fix bug in x86 cmpset
Date: Fri, 27 Oct 2017 00:03:10 +0200
Message-ID: <4412880.1l5vTf8byN@xps>
References: <1475184293-18298-1-git-send-email-nikhil.rao@intel.com>
 <2295899.BebvH11edl@xps13>
 <20170904125932.GA21808@bricha3-MOBL3.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, "Hunt, David" <david.hunt@intel.com>,
 Konstantin Ananyev <konstantin.ananyev@intel.com>
To: Bruce Richardson <bruce.richardson@intel.com>,
 Nikhil Rao <nikhil.rao@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 48A1C1BB26
 for <dev@dpdk.org>; Fri, 27 Oct 2017 00:03:12 +0200 (CEST)
In-Reply-To: <20170904125932.GA21808@bricha3-MOBL3.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

04/09/2017 15:02, Bruce Richardson:
> Couple of other comments on this code area that should be taken into
> account:
> 1. the indentation of the asm code looks wrong, and should probably be
>    fixed to make it more readable.
> 2. the comment on the "D" register is wrong as it refers to ebx
> 3. the fact that we can't use ebx, and instead use edi and swap twice
>    should be commented.

A patch to fix all these comments would be welcome :)

> For the fix itself:
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied (more than one year after the submission), thanks