From: Jeff Garzik <jgarzik@pobox.com>
To: Tejun Heo <htejun@gmail.com>
Cc: albertcc@tw.ibm.com, linux-ide@vger.kernel.org
Subject: Re: [PATCH 2/4] libata: convert pio_task and packet_task to port_task
Date: Sat, 11 Mar 2006 18:43:29 -0500 [thread overview]
Message-ID: <441360A1.7080402@pobox.com> (raw)
In-Reply-To: <114154014972-git-send-email-htejun@gmail.com>
Tejun Heo wrote:
> Make pio_task and atapi_packet_task use port_task.
> atapi_packet_task() is moved upward such that it's right after
> ata_pio_task(). This position is more natural and makes adding
> prototype for ata_qc_issue_prot() unnecessary.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
Applied 1-4, though in the future, please -do not- include function
shuffling in the same patch as other changes. atapi_packet_task() has
been moved all over the place, over the lifetime of libata, and it just
clutters up cumulative diffs at review time.
Jeff
next prev parent reply other threads:[~2006-03-11 23:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-05 6:29 [PATCHSET] implement and use port_task Tejun Heo
2006-03-05 6:29 ` [PATCH 2/4] libata: convert pio_task and packet_task to port_task Tejun Heo
2006-03-11 23:43 ` Jeff Garzik [this message]
2006-03-05 6:29 ` [PATCH 1/4] libata: implement port_task Tejun Heo
2006-03-05 16:09 ` Jeff Garzik
2006-03-05 16:23 ` Tejun Heo
2006-03-05 6:29 ` [PATCH 3/4] libata: kill unused pio_task and packet_task Tejun Heo
2006-03-05 6:29 ` [PATCH 4/4] libata: rename ATA_FLAG_FLUSH_PIO_TASK to ATA_FLAG_FLUSH_PORT_TASK Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=441360A1.7080402@pobox.com \
--to=jgarzik@pobox.com \
--cc=albertcc@tw.ibm.com \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.