From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <htejun@gmail.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] AHCI prefetch
Date: Sat, 11 Mar 2006 19:32:19 -0500 [thread overview]
Message-ID: <44136C13.4020002@garzik.org> (raw)
In-Reply-To: <20060310043717.GA7510@htj.dyndns.org>
Tejun Heo wrote:
> On Sat, Mar 04, 2006 at 12:35:05PM -0500, Jeff Garzik wrote:
>
>>This patch has been sitting in my tmp directory for ages.
>>
>>We should probably turn this on, though the practical difference is
>>probably minimal.
>>
>
>
> The patch works okay on my machine (ICH7R) although the patch didn't
> apply to #upstream. I'm not very sure about this change though.
>
> 1. Why apply it only to ATAPI devices? ATA devices can benefit to.
> If it's because this bit shouldn't be turned on for NCQ, we can
> turn it on conditionally. We'll probably need similar condition
> for ATAPI devices too if we support FIS-based PM switching.
Main reason is that it will largely only have benefits on ATAPI devices,
and I've only tested it on ATAPI devices.
> 2. I'm a bit skeptical whether this change will bring any noticeable
> performance improvement. OTOH, this seems to be a good source for
Agreed.
> obscure problems on some controllers which might not implement/test
> this feature properly. As more controllers implement AHCI spec,
> the possibility grows.
Agreed.
> Anyways, here's the patch regenerated against #upstream.
Could I trouble you for a resend, with a proper signed-off-by and patch
description?
Jeff
next prev parent reply other threads:[~2006-03-12 0:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-04 17:35 [PATCH] AHCI prefetch Jeff Garzik
2006-03-10 4:37 ` Tejun Heo
2006-03-12 0:32 ` Jeff Garzik [this message]
2006-03-12 2:25 ` [PATCH] ahci: enable prefetching for PACKET commands Tejun Heo
2006-03-12 2:30 ` [PATCH] ahci: enable prefetching Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44136C13.4020002@garzik.org \
--to=jeff@garzik.org \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.