All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Stuebner <heiko@sntech.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 01/20] SPL: FIT: refactor FDT loading
Date: Fri, 05 May 2017 17:39:18 +0200	[thread overview]
Message-ID: <4415239.66urlALPts@phil> (raw)
In-Reply-To: <1493166772-24598-2-git-send-email-andre.przywara@arm.com>

Am Mittwoch, 26. April 2017, 01:32:33 CEST schrieb Andre Przywara:
> Currently the SPL FIT loader uses the spl_fit_select_fdt() function to
> find the offset to the right DTB within the FIT image.
> For this it iterates over all subnodes of the /configuration node in
> the FIT tree and compares all "description" strings therein using a
> board specific matching function.
> If that finds a match, it uses the string in the "fdt" property of that
> subnode to locate the matching subnode in the /images node, which points
> to the DTB data.
> Now this works very well, but is quite specific to cover this particular
> use case. To open up the door for a more generic usage, let's split this
> function into:
> 1) a function that just returns the node offset for the matching
>    configuration node (spl_fit_find_config_node())
> 2) a function that returns the image data any given property in a given
>    configuration node points to, additionally using a given index into
>    a possbile list of strings (spl_fit_select_index())
> This allows us to replace the specific function above by asking for the
> image the _first string of the "fdt" property_ in the matching
> configuration subnode points to.
> 
> This patch introduces no functional changes, it just refactors the code
> to allow reusing it later.
> 
> (diff is overly clever here and produces a hard-to-read patch, so I
> recommend to throw a look at the result instead).
> 
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> Reviewed-by: Lokesh Vutla <lokeshvuta@ti.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>

On a rk3399-firefly
Tested-by: Heiko Stuebner <heiko@sntech.de>

  reply	other threads:[~2017-05-05 15:39 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-26  0:32 [U-Boot] [PATCH v4 00/20] SPL: extend FIT loading support Andre Przywara
2017-04-26  0:32 ` [U-Boot] [PATCH v4 01/20] SPL: FIT: refactor FDT loading Andre Przywara
2017-05-05 15:39   ` Heiko Stuebner [this message]
2017-05-16  1:34   ` Kever Yang
2017-05-16  7:40   ` Lokesh Vutla
2017-04-26  0:32 ` [U-Boot] [PATCH v4 02/20] SPL: FIT: rework U-Boot image loading Andre Przywara
2017-05-05 15:39   ` Heiko Stuebner
2017-05-16  1:35   ` Kever Yang
2017-04-26  0:32 ` [U-Boot] [PATCH v4 03/20] SPL: FIT: improve error handling Andre Przywara
2017-05-05 15:39   ` Heiko Stuebner
2017-05-16  1:36   ` Kever Yang
2017-04-26  0:32 ` [U-Boot] [PATCH v4 04/20] SPL: FIT: factor out spl_load_fit_image() Andre Przywara
2017-05-05 15:40   ` Heiko Stuebner
2017-05-16  1:36   ` Kever Yang
2017-04-26  0:32 ` [U-Boot] [PATCH v4 05/20] SPL: FIT: allow loading multiple images Andre Przywara
2017-05-05 15:40   ` Heiko Stuebner
2017-05-16  1:37   ` Kever Yang
2017-04-26  0:32 ` [U-Boot] [PATCH v4 06/20] Kconfig: fix SPL_FIT dependency Andre Przywara
2017-04-29  0:27   ` Simon Glass
2017-04-26  0:32 ` [U-Boot] [PATCH v4 07/20] tools: mksunxiboot: allow larger SPL binaries Andre Przywara
2017-04-26  0:32 ` [U-Boot] [PATCH v4 08/20] armv8: SPL: only compile GIC code if needed Andre Przywara
2017-04-26  0:32 ` [U-Boot] [PATCH v4 09/20] armv8: fsl: move ccn504 code into FSL Makefile Andre Przywara
2017-04-26  0:32 ` [U-Boot] [PATCH v4 10/20] sunxi: A64: move SPL stack to end of SRAM A2 Andre Przywara
2017-04-26  0:32 ` [U-Boot] [PATCH v4 11/20] sunxi: SPL: store RAM size in gd Andre Przywara
2017-04-26  0:32 ` [U-Boot] [PATCH v4 12/20] sunxi: SPL: add FIT config selector for Pine64 boards Andre Przywara
2017-04-26  0:32 ` [U-Boot] [PATCH v4 13/20] Makefile: add rules to generate SPL FIT images Andre Przywara
2017-04-26  0:32 ` [U-Boot] [PATCH v4 14/20] sunxi: 64-bit SoCs: introduce FIT generator script Andre Przywara
2017-04-26  0:32 ` [U-Boot] [PATCH v4 15/20] sunxi: defconfig: add supported DT list for Pine64 Andre Przywara
2017-05-05 19:55   ` Jagan Teki
2017-05-08 13:44     ` Andre Przywara
2017-05-14  9:32   ` Simon Glass
2017-04-26  0:32 ` [U-Boot] [PATCH v4 16/20] sunxi: enable automatic FIT build for 64-bit SoCs Andre Przywara
2017-04-26  0:32 ` [U-Boot] [PATCH v4 17/20] sunxi: Store the device tree name in the SPL header Andre Przywara
2017-04-26  0:32 ` [U-Boot] [PATCH v4 18/20] sunxi: use SPL header DT name for FIT board matching Andre Przywara
2017-04-26  0:32 ` [U-Boot] [PATCH v4 19/20] sunxi: update Pine64 README Andre Przywara
2017-04-26  0:32 ` [U-Boot] [PATCH v4 20/20] sunxi: Move maintainership for Pine64 Andre Przywara
2017-05-16  1:40 ` [U-Boot] [PATCH v4 00/20] SPL: extend FIT loading support Kever Yang
2017-05-16  8:10   ` Andre Przywara
2017-05-16 20:07     ` Mark Kettenis
2017-05-17  1:37       ` Simon Glass
2017-05-17 17:59 ` Jagan Teki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4415239.66urlALPts@phil \
    --to=heiko@sntech.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.