All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylylov <sshtylyov@ru.mvista.com>
To: Linux MIPS <linux-mips@linux-mips.org>
Cc: Jordan Crouse <jordan.crouse@amd.com>
Subject: [PATCH] Alchemy: make OSS I2S driver build
Date: Tue, 14 Mar 2006 06:21:58 +0300	[thread overview]
Message-ID: <441636D6.80500@ru.mvista.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 454 bytes --]

Hello.

     Alchemy OSS I2S driver (sound/oss/au1550_i2s.c) doesn't build if I2C 
driver (drivers/i2c/busses/i2c_au1550.c) is not enabled because 
pb1550_wm_codec_write() is defined there (a dirty hack). So, mark that 
dependency in drivers/i2c/busses/Kconfig.

WBR, Sergei

PS: Also, I've noticed that both I2S and I2C drivers depend solely on
SOC_AU1550. Shouldn't they also work on Au1200?

Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>



[-- Attachment #2: Au1550-I2S-depends-on-I2C.patch --]
[-- Type: text/plain, Size: 459 bytes --]

diff --git a/sound/oss/Kconfig b/sound/oss/Kconfig
index b7bd8ab..07eb4a7 100644
--- a/sound/oss/Kconfig
+++ b/sound/oss/Kconfig
@@ -242,6 +242,9 @@ config SOUND_AU1550_AC97
 config SOUND_AU1550_I2S
 	tristate "Au1550 I2S Sound"
 	depends on SOUND_PRIME && SOC_AU1550
+	# Weird I2S driver needs I2C driver to talk to the codec...
+	select I2C
+	select I2C_AU1550
 
 config SOUND_TRIDENT
 	tristate "Trident 4DWave DX/NX, SiS 7018 or ALi 5451 PCI Audio Core"


                 reply	other threads:[~2006-03-14  3:14 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=441636D6.80500@ru.mvista.com \
    --to=sshtylyov@ru.mvista.com \
    --cc=jordan.crouse@amd.com \
    --cc=linux-mips@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.