From: Steven Scholz <steven.scholz@imc-berlin.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] Bug in DTT for temperatures below zero degress !!!
Date: Tue, 14 Mar 2006 09:49:11 +0100 [thread overview]
Message-ID: <44168387.5010604@imc-berlin.de> (raw)
In-Reply-To: <20060312145444.1E148352616@atlas.denx.de>
Wolfgang Denk wrote:
>> - return (dtt_read(sensor, DTT_READ_TEMP) / 256);
>> + return ( ((signed short) dtt_read(sensor, DTT_READ_TEMP)) / 256);
>
> This is not the right way to fix it. I reject this patch.
>
> dtt_read() is declared to return "int", so no such cast should be
> needed, i. e. you fix the symptoms instead of the cause.
You're probably right. But at the moment I have no access to suitable
hardware and I am off for a two weeks vacations today.
I promise to test this when I am back.
Thansk.
--
Steven
prev parent reply other threads:[~2006-03-14 8:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-15 8:50 [U-Boot-Users] Bug in DTT for temperatures below zero degress !!! Steven Scholz
2006-03-12 14:54 ` Wolfgang Denk
2006-03-14 8:49 ` Steven Scholz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44168387.5010604@imc-berlin.de \
--to=steven.scholz@imc-berlin.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.