All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@novell.com>
To: Keir Fraser <Keir.Fraser@cl.cam.ac.uk>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH] i386 linux: make 32-bit PAE kernel work when built with newer gcc
Date: Tue, 14 Mar 2006 11:40:25 +0100	[thread overview]
Message-ID: <4416ABA9.76F0.0078.0@novell.com> (raw)
In-Reply-To: <cb45320bb2b0d8512fa96223edcd6d51@cl.cam.ac.uk>

>>> Keir Fraser <Keir.Fraser@cl.cam.ac.uk> 14.03.06 11:09:29 >>>
>
>On 13 Mar 2006, at 16:40, Jan Beulich wrote:
>
>> The compiler isn't required to order the two stores 
>> ptep_get_and_clear_full() in any particular way, and we saw cases
>> where the upper 32 bits get stored before the lower ones, which causes 
>> the access to fail (page-fault propagated out of
>> Xen).
>
>Won't this need a barrier() (compile barrier) between the updates of 
>low and high portions?

No, I can't see why. The compiler isn't permitted to re-order separate writes across
sequence points (which is different from a single 64-bit write, where the compiler is
only expected to carry out the full 64-bit write prior to the next sequence point, but
nothing requires it to do this in any particular order).

Jan

  reply	other threads:[~2006-03-14 10:40 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-13 16:40 [PATCH] i386 linux: make 32-bit PAE kernel work when built with newer gcc Jan Beulich
2006-03-14 10:09 ` Keir Fraser
2006-03-14 10:40   ` Jan Beulich [this message]
2006-03-14 11:53     ` Keir Fraser
2006-03-14 12:40       ` Jan Beulich
2006-03-14 14:06         ` Keir Fraser
2006-03-14 14:31           ` Jan Beulich
2006-03-14 14:39             ` Keir Fraser
2006-03-17 10:19 ` Keir Fraser
2006-03-17 11:35   ` Jan Beulich
2006-03-17 11:51     ` Keir Fraser
2006-03-17 12:28       ` Jan Beulich
2006-03-17 13:24         ` Keir Fraser
2006-03-17 13:37           ` Jan Beulich
  -- strict thread matches above, loose matches on Subject: below --
2006-03-14 12:15 Petersson, Mats

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4416ABA9.76F0.0078.0@novell.com \
    --to=jbeulich@novell.com \
    --cc=Keir.Fraser@cl.cam.ac.uk \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.