All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Hancock <hancockr@shaw.ca>
To: Herbert Rosmanith <kernel@wildsau.enemy.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: procfs uglyness caused by "cat"
Date: Tue, 14 Mar 2006 08:35:15 -0600	[thread overview]
Message-ID: <4416D4A3.9070705@shaw.ca> (raw)
In-Reply-To: <5Qfgo-3At-15@gated-at.bofh.it>

Herbert Rosmanith wrote:
> a simple way to get rid of this:
> 
> static int uptime_read_proc(char *page, char **start, off_t off,
>                                  int count, int *eof, void *data)
> {
>         struct timespec uptime;
>         struct timespec idle;
>         int len;
>         cputime_t idletime;
> 
> +	if (off)
> +		return 0;

Except that this is wrong - if you try to advance the offset a bit from 
the start of the file and read something, you'll get nothing. This is 
inconsistent with normal file behavior.

-- 
Robert Hancock      Saskatoon, SK, Canada
To email, remove "nospam" from hancockr@nospamshaw.ca
Home Page: http://www.roberthancock.com/


       reply	other threads:[~2006-03-14 14:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <5Qfgo-3At-15@gated-at.bofh.it>
2006-03-14 14:35 ` Robert Hancock [this message]
2006-03-14 15:33   ` procfs uglyness caused by "cat" Paul Rolland
2006-03-14 17:59     ` Paul Jackson
2006-03-14 18:45       ` Paul Rolland
2006-03-15  8:06   ` Herbert Rosmanith
2006-03-15  8:23   ` Herbert Rosmanith
2006-03-14 10:43 Herbert Rosmanith
2006-03-14 15:57 ` Paul Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4416D4A3.9070705@shaw.ca \
    --to=hancockr@shaw.ca \
    --cc=kernel@wildsau.enemy.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.