All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felipe W Damasio <felipewd@terra.com.br>
To: Eugene Teo <eugene.teo@eugeneteo.net>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>, jkmaline@cc.hut.fi
Subject: Re: Fix hostap_cs double kfree
Date: Wed, 15 Mar 2006 00:05:13 -0300	[thread overview]
Message-ID: <44178469.3090907@terra.com.br> (raw)
In-Reply-To: <20060315023900.GA8179@eugeneteo.net>

    Hi Eugene,

Eugene Teo wrote:

>  failed:
>-	kfree(parse);
>-	kfree(hw_priv);
>+	if (parse)
>+		kfree(parse);
>+	if (hw_priv)
>+		kfree(hw_priv);
> 	prism2_release((u_long)link);
> 	return ret;
> }
>  
>
    I don't think those if's are needed, since the kfree code already does:

void kfree(const void *objp)
{
        if (unlikely(!objp))
                return;
...
}

    But if you really want to use it, I suggest using if (likely
(!<pointer>)) there to hint gcc of a possible optimization.

    Cheers,

Felipe Damasio

  reply	other threads:[~2006-03-15  3:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-15  2:39 Fix hostap_cs double kfree Eugene Teo
2006-03-15  3:05 ` Felipe W Damasio [this message]
2006-03-15  3:55   ` Eugene Teo
2006-03-15  3:14 ` Jouni Malinen
2006-03-15  6:44   ` Eugene Teo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44178469.3090907@terra.com.br \
    --to=felipewd@terra.com.br \
    --cc=eugene.teo@eugeneteo.net \
    --cc=jkmaline@cc.hut.fi \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.