From: Patrick McHardy <kaber@trash.net>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: netfilter-devel@lists.netfilter.org
Subject: Re: ip_conntrack build warning
Date: Thu, 16 Mar 2006 00:50:38 +0100 [thread overview]
Message-ID: <4418A84E.5080406@trash.net> (raw)
In-Reply-To: <20060315112315.6158ad7c@localhost.localdomain>
Stephen Hemminger wrote:
> Recent kernels in -mm warn about init section usage in ip_conntrack.
> The problem is the init_or_cleanup() style makes it impossible to compile
> time checking hard.
>
> WARNING: net/ipv4/netfilter/ip_conntrack.o - Section mismatch:
> reference to .init.text:ip_conntrack_init from .text.init_or_cleanup
> after 'init_or_cleanup' (at offset 0x12)
The code should be fine, although I'm not a big fan of these
functions either. ip_conntrack_init is marked __init and is
called from init_or_cleanup, which is not marked, but only
on the init path.
I'd happily take a patch which cleans up these functions (we
have lots of them in the netfilter code).
next prev parent reply other threads:[~2006-03-15 23:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-15 19:23 ip_conntrack build warning Stephen Hemminger
2006-03-15 23:50 ` Patrick McHardy [this message]
2006-03-15 23:52 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4418A84E.5080406@trash.net \
--to=kaber@trash.net \
--cc=netfilter-devel@lists.netfilter.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.