From: Nick Piggin <nickpiggin@yahoo.com.au>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: [PATCH] for_each_possible_cpu [1/19] defines for_each_possible_cpu
Date: Thu, 16 Mar 2006 15:24:25 +1100 [thread overview]
Message-ID: <4418E879.3000207@yahoo.com.au> (raw)
In-Reply-To: <20060316131743.d7b716e9.kamezawa.hiroyu@jp.fujitsu.com>
KAMEZAWA Hiroyuki wrote:
> On Thu, 16 Mar 2006 14:43:38 +1100
> Nick Piggin <nickpiggin@yahoo.com.au> wrote:
>
>
>>The only places where things might care is arch bootup code, but
>>the cpu interface is such that the arch code is expected to _hide_
>>any weird details from these generic interfaces.
>>
>
> Please see i386 patch. it contains BUG fix.
> cpu_msrs[i].coutners are allocated by for_each_online_cpu().
> and free it by for_each_possible_cpus() without no pointer check.
>
Well that's another problem then, such a fix should not be sent in
this patchset, but as a separate patch.
> I think this kind of confusion will be seen again in future.
I'm sure that renaming for_each_cpu would not prevent that either.
--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com
next prev parent reply other threads:[~2006-03-16 5:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-16 3:21 [PATCH] for_each_possible_cpu [1/19] defines for_each_possible_cpu KAMEZAWA Hiroyuki
2006-03-16 3:40 ` Andrew Morton
2006-03-16 4:13 ` KAMEZAWA Hiroyuki
2006-03-16 3:43 ` Nick Piggin
2006-03-16 3:55 ` Andrew Morton
2006-03-16 4:08 ` Nick Piggin
2006-03-16 4:17 ` KAMEZAWA Hiroyuki
2006-03-16 4:24 ` Nick Piggin [this message]
2006-03-16 6:22 ` KAMEZAWA Hiroyuki
2006-03-16 6:49 ` Nick Piggin
2006-03-16 9:48 ` Andrew Morton
2006-03-16 10:04 ` Nick Piggin
2006-03-16 4:33 ` YOSHIFUJI Hideaki / 吉藤英明
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4418E879.3000207@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=akpm@osdl.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.