From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Jonathan Corbet <corbet@lwn.net>, akpm@osdl.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: RFC: radix tree safety
Date: Fri, 17 Mar 2006 11:41:54 +1100 [thread overview]
Message-ID: <441A05D2.7070803@yahoo.com.au> (raw)
In-Reply-To: <20060316171320.1572.qmail@lwn.net>
Jonathan Corbet wrote:
> Nick Piggin <nickpiggin@yahoo.com.au> wrote:
>
>
>>How about making the code self-documenting and more useful at the same
>>time: put RADIX_TREE_TAGS in radix-tree.h, and call it RADIX_TREE_MAX_TAGS
>
>
> I like that idea - how's the following? I also took the liberty of
> making the tag arguments be unsigned, since that is clearly the way they
> are intended to be used.
>
Looks really good. Andrew will you pick it up?
> jon
>
>
> Documentation changes to help radix tree users avoid overrunning the
> tags array. RADIX_TREE_TAGS moves to linux/radix-tree.h and is now
> known as RADIX_TREE_MAX_TAGS (Nick Piggin's idea). Tag parameters are
> changed to unsigned, and some comments are updated.
>
> Signed-off-by: Jonathan Corbet <corbet@lwn.net>
...
--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com
next prev parent reply other threads:[~2006-03-17 0:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-13 22:43 RFC: radix tree safety Jonathan Corbet
2006-03-13 22:55 ` Nick Piggin
2006-03-13 23:50 ` Andrew Morton
2006-03-14 0:01 ` Jonathan Corbet
2006-03-14 0:14 ` Andrew Morton
2006-03-14 5:24 ` Nick Piggin
2006-03-16 17:13 ` Jonathan Corbet
2006-03-17 0:41 ` Nick Piggin [this message]
2006-03-13 23:03 ` Randy.Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=441A05D2.7070803@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=akpm@osdl.org \
--cc=corbet@lwn.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.