All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: albertl@mail.com
Cc: Mark Lord <lkml@rtr.ca>, Jens Axboe <axboe@suse.de>,
	me_trash1@aon.at, linux-ide@vger.kernel.org
Subject: Re: LibPATA code issues / 2.6.15.4
Date: Fri, 17 Mar 2006 04:57:35 -0500	[thread overview]
Message-ID: <441A880F.7010204@pobox.com> (raw)
In-Reply-To: <441A80CA.6080407@tw.ibm.com>

Albert Lee wrote:
> How about the attached renaming patch?
> It could make the command names more consistent to what's in the ATA/ATAPI spec.
> 
> ---
> Albert
> 
> 
> Changes:
> 
> ATA_CMD_READ        => ATA_CMD_READ_DMA
> ATA_CMD_WRITE       => ATA_CMD_WRITE_DMA
> ...
> ATA_CMD_PIO_READ    => ATA_CMD_READ_PIO
> ATA_CMD_PIO_WRITE   => ATA_CMD_WRITE_PIO
> ...
> ATA_CMD_FPDMA_READ  => ATA_CMD_READ_FPDMA_QUEUED
> ATA_CMD_FPDMA_WRITE => ATA_CMD_WRITE_FPDMA_QUEUED


Even given the current thread's confusion, I rather like the existing 
names.  Everybody does DMA these days, so ATA_CMD_WRITE being of DMA 
protocol seems the most natural to me.

	Jeff



  reply	other threads:[~2006-03-17  9:58 UTC|newest]

Thread overview: 127+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-14 13:50 LibPATA code issues / 2.6.15.4 me_trash1
2006-03-15 15:03 ` Mark Lord
2006-03-16 10:08   ` Jens Axboe
2006-03-17  5:26     ` Mark Lord
2006-03-17  9:26       ` Albert Lee
2006-03-17  9:57         ` Jeff Garzik [this message]
2006-03-17 15:20           ` Eric D. Mudama
2006-03-17 15:20         ` Mark Lord
2006-03-17 15:29           ` Tejun Heo
2006-03-16  0:19 ` markus ebenhoeh
  -- strict thread matches above, loose matches on Subject: below --
2006-03-01 19:00 Nicolas Mailhot
2006-03-01 19:22 ` Mark Lord
2006-03-01 23:12   ` Nicolas Mailhot
2006-03-01 23:31     ` Jeff Garzik
2006-03-02  1:19     ` Eric D. Mudama
2006-03-02  1:39       ` Eric D. Mudama
2006-02-14  9:48 Justin Piszcz
2006-02-14 14:50 ` Mark Lord
2006-02-14 16:27   ` David Greaves
2006-02-14 17:12     ` Justin Piszcz
2006-02-14 18:00       ` Mark Lord
2006-02-14 18:06         ` Justin Piszcz
2006-02-23 23:39         ` Justin Piszcz
2006-02-25 15:32           ` Mark Lord
2006-02-25 15:58             ` Justin Piszcz
2006-02-25 16:11               ` Jesper Juhl
2006-02-25 16:21               ` Mark Lord
2006-02-25 11:34         ` David Greaves
2006-02-25 16:20           ` Mark Lord
2006-02-25 17:45             ` Justin Piszcz
2006-02-25 18:28               ` Mark Lord
2006-02-25 18:55                 ` Justin Piszcz
2006-02-25 19:29                 ` Justin Piszcz
2006-02-25 19:53                   ` David Greaves
2006-02-25 19:47                 ` David Greaves
2006-02-26  2:27                   ` Mark Lord
2006-02-26  9:56                     ` David Greaves
2006-02-26 14:04                       ` Mark Lord
2006-02-27 21:34                         ` Mark Lord
2006-02-28  1:33                           ` Tejun Heo
2006-02-28  1:46                             ` Linus Torvalds
2006-02-28  2:07                               ` Jeff Garzik
2006-02-28  2:14                                 ` Linus Torvalds
2006-02-28  2:52                                   ` Jeff Garzik
2006-02-28  3:36                                   ` Jeff Garzik
2006-02-28  4:11                                     ` Mark Lord
2006-02-28 10:30                                 ` Alan Cox
2006-02-28  8:03                               ` Jens Axboe
2006-02-28  4:16                             ` Mark Lord
2006-02-28 10:32                               ` Alan Cox
2006-02-28 10:30                                 ` Justin Piszcz
2006-02-28 10:39                               ` David Greaves
2006-02-28 14:37                                 ` Mark Lord
2006-02-28 21:04                                   ` Bill Davidsen
2006-03-08  2:57                                     ` Mark Lord
2006-03-08  3:18                                       ` Dave Jones
2006-03-08  3:23                                         ` Mark Lord
2006-03-08 15:37                                       ` Bill Davidsen
2006-03-08 15:37                                         ` Bill Davidsen
2006-02-28 14:38                                 ` Mark Lord
     [not found]                                   ` <Pine.LNX.4.64.0602280939280.16541@p34>
2006-02-28 14:49                                     ` Mark Lord
2006-02-28 15:07                                       ` Jeff Garzik
2006-02-28 15:26                                         ` Mark Lord
2006-02-28 15:33                                           ` Jeff Garzik
2006-03-01  0:46                                             ` Mark Lord
2006-03-01  6:01                                               ` Jeff Garzik
2006-02-28 15:16                                   ` Alan Cox
2006-03-01 17:33                                     ` David Greaves
2006-03-01 18:37                                       ` Alan Cox
2006-03-01 20:12                                         ` Phillip Susi
2006-03-08 16:46                                           ` Alan Cox
2006-02-28 15:31                                 ` Mark Lord
2006-02-28 15:34                                   ` Jeff Garzik
2006-02-28 16:57                                     ` Eric D. Mudama
2006-03-01  1:04                                       ` Mark Lord
2006-03-01 11:37                                         ` Justin Piszcz
2006-03-01 13:17                                         ` Justin Piszcz
2006-03-01 17:41                                     ` David Greaves
2006-03-01 17:46                                       ` Mark Lord
2006-03-01 18:12                                         ` David Greaves
2006-03-01 18:30                                           ` Mark Lord
2006-03-01 18:32                                             ` Justin Piszcz
2006-03-01 18:33                                             ` Justin Piszcz
2006-03-01 18:48                                             ` David Greaves
2006-03-01 19:49                                               ` David Greaves
2006-03-03 19:38                                                 ` Justin Piszcz
2006-03-03 22:46                                                   ` David Greaves
2006-03-04 14:25                                                     ` Mark Lord
2006-03-06  6:13                                                       ` David Greaves
2006-03-21 18:11                                                         ` David Greaves
2006-03-22 15:23                                                           ` David Greaves
2006-03-05 11:43                                                 ` Justin Piszcz
2006-03-05 12:41                                                   ` Justin Piszcz
2006-03-05 22:58                                                     ` Mark Lord
2006-03-05 23:00                                                       ` Mark Lord
2006-03-05 23:19                                                         ` Justin Piszcz
2006-03-05 23:39                                                       ` Jeff Garzik
2006-03-01 19:06                                             ` Justin Piszcz
2006-03-01 19:28                                               ` Mark Lord
2006-03-01 19:35                                               ` Mark Lord
2006-03-01 19:38                                                 ` Justin Piszcz
2006-03-01 19:41                                                   ` Jeff Garzik
2006-02-26 12:27                     ` James Courtier-Dutton
2006-02-26 12:55                       ` David Greaves
2006-02-26 13:56                       ` Mark Lord
2006-02-14 23:58   ` Justin Piszcz
2006-02-17  8:45   ` Jeff Garzik
2006-02-17 14:59     ` Mark Lord
2006-02-17 15:00       ` Justin Piszcz
2006-02-18 20:43       ` Sander
2006-02-18 21:42         ` Mark Lord
2006-02-18 21:51           ` Justin Piszcz
2006-02-19  7:14           ` Sander
2006-02-19 15:30             ` Mark Lord
2006-02-19 17:16               ` Sander
2006-07-06 23:08                 ` Justin Piszcz
2006-07-07 13:08                   ` Mark Lord
2006-07-07 13:24                     ` Justin Piszcz
2006-07-07 13:43                       ` Mark Lord
2006-07-07 13:48                         ` Justin Piszcz
2006-07-07 14:01                         ` Justin Piszcz
2006-07-07 14:35                         ` Justin Piszcz
2006-07-07 18:53                           ` Justin Piszcz
2006-07-07 19:19                             ` Jeff Garzik
2006-07-07 19:28                               ` Justin Piszcz
     [not found]                                 ` <200607091224.31451.liml@rtr.ca>
2006-07-09 17:27                                   ` Justin Piszcz
2006-07-09 20:16                                     ` Justin Piszcz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=441A880F.7010204@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=albertl@mail.com \
    --cc=axboe@suse.de \
    --cc=linux-ide@vger.kernel.org \
    --cc=lkml@rtr.ca \
    --cc=me_trash1@aon.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.