From: Oleg Nesterov <oleg@tv-sign.ru>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Linus Torvalds <torvalds@osdl.org>,
linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
Janak Desai <janak@us.ibm.com>, Al Viro <viro@ftp.linux.org.uk>,
Christoph Hellwig <hch@lst.de>,
Michael Kerrisk <mtk-manpages@gmx.net>, Andi Kleen <ak@muc.de>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH] unshare: Use rcu_assign_pointer when setting sighand
Date: Fri, 17 Mar 2006 20:44:54 +0300 [thread overview]
Message-ID: <441AF596.F6E66BC9@tv-sign.ru> (raw)
In-Reply-To: m1pskm9tz9.fsf@ebiederm.dsl.xmission.com
"Eric W. Biederman" wrote:
>
> @@ -1573,7 +1573,7 @@ asmlinkage long sys_unshare(unsigned lon
>
> if (new_sigh) {
> sigh = current->sighand;
> - current->sighand = new_sigh;
> + rcu_assign_pointer(current->sighand, new_sigh);
> new_sigh = sigh;
> }
Isn't it better to just replace this code with
'BUG_ON(new_sigh != NULL)' ?
It is never executed, but totally broken, afaics.
task_lock() has nothing to do with ->sighand changing.
Oleg.
next prev parent reply other threads:[~2006-03-17 17:48 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-16 16:49 [PATCH] unshare: Cleanup up the sys_unshare interface before we are committed Eric W. Biederman
2006-03-16 17:31 ` [PATCH] unshare: Use rcu_assign_pointer when setting sighand Eric W. Biederman
2006-03-17 6:48 ` Paul E. McKenney
2006-03-17 17:44 ` Oleg Nesterov [this message]
2006-03-17 20:56 ` Andrew Morton
2006-03-18 13:12 ` Oleg Nesterov
2006-03-18 15:43 ` Janak Desai
2006-03-18 17:24 ` Oleg Nesterov
2006-03-18 17:41 ` [PATCH] for 2.6.16, disable unshare_vm() Oleg Nesterov
2006-03-18 18:10 ` Linus Torvalds
2006-03-18 18:29 ` Ulrich Drepper
2006-03-18 18:48 ` Janak Desai
2016-03-14 13:15 ` unshare(CLONE_VM) Re: [PATCH] unshare: Use rcu_assign_pointer when setting sighand Julian Smith
2016-03-14 18:35 ` Linus Torvalds
2006-03-18 13:13 ` [PATCH] implement unshare(CLONE_SIGHAND) for single-thread case Oleg Nesterov
2006-03-18 15:10 ` [PATCH] unshare: Error if passed unsupported flags Eric W. Biederman
2006-03-18 15:33 ` Janak Desai
2006-03-18 16:29 ` [PATCH] unshare: Use rcu_assign_pointer when setting sighand Janak Desai
2006-03-16 19:40 ` [PATCH] unshare: Cleanup up the sys_unshare interface before we are committed Michael Kerrisk
2006-03-16 20:33 ` Andrew Morton
2006-03-16 20:41 ` Linus Torvalds
2006-03-16 21:58 ` Eric W. Biederman
2006-03-16 22:19 ` Andrew Morton
2006-03-16 21:36 ` Janak Desai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=441AF596.F6E66BC9@tv-sign.ru \
--to=oleg@tv-sign.ru \
--cc=ak@muc.de \
--cc=akpm@osdl.org \
--cc=ebiederm@xmission.com \
--cc=hch@lst.de \
--cc=janak@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mtk-manpages@gmx.net \
--cc=paulus@samba.org \
--cc=torvalds@osdl.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.