All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tilman Schmidt <tilman@imap.cc>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] usb.h: reduce syslog clutter
Date: Mon, 20 Mar 2006 19:40:49 +0000	[thread overview]
Message-ID: <441F0541.60008@imap.cc> (raw)
In-Reply-To: <441C6536.2060800@imap.cc>


[-- Attachment #1.1: Type: text/plain, Size: 1033 bytes --]

Arnd Bergmann wrote:

> On Saturday 18 March 2006 20:53, Tilman Schmidt wrote:
>> +#if defined(CONFIG_MODULES) && defined(THIS_MODULE)
>> +#define KMSG_LOCATION_PREFIX THIS_MODULE ? THIS_MODULE->name : __FILE__
>> +#else
>> +#define KMSG_LOCATION_PREFIX __FILE__
>> +#endif
>> +
> 
> Shouldn't this simply use KBUILD_MODNAME?

Thanks for the hint. I didn't know this expands to __FILE__ when not
compiling for a module. That's perfect!

A small drawback is that, according to scripts/Makefile.lib:

"It's possible that one object gets potentially linked into more
 than one module. In that case KBUILD_MODNAME will be set to foo_bar,
 where foo and bar are the name of the modules."

But I assume that's so rare it wouldn't warrant the more complicated
solution I proposed.

Second take of patch follows.

-- 
Tilman Schmidt                          E-Mail: tilman@imap.cc
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 253 bytes --]

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

  parent reply	other threads:[~2006-03-20 19:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-18 19:53 [KJ] [PATCH] usb.h: reduce syslog clutter Tilman Schmidt
2006-03-20  9:54 ` Arnd Bergmann
2006-03-20 19:40 ` Tilman Schmidt [this message]
2006-03-20 19:44 ` Tilman Schmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=441F0541.60008@imap.cc \
    --to=tilman@imap.cc \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.