From: Sergei Shtylylov <sshtylyov@ru.mvista.com>
To: alsa-devel@lists.sourceforge.net
Cc: Jordan Crouse <jordan.crouse@amd.com>
Subject: [PATCH] AMD Au1x00: AC'97 controller is memory mapped
Date: Tue, 21 Mar 2006 00:17:34 +0300 [thread overview]
Message-ID: <441F1BEE.8080307@ru.mvista.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 202 bytes --]
Hello.
AMD Au1x00 ALSA driver erroneously calls request_region() for AC'97
controller registers -- the controller is actually memory mapped at addresses
0x10000000 thru 0x100FFFFF.
WBR, Sergei
[-- Attachment #2: Au1x00-ALSA-AC97-memory-mapped.patch --]
[-- Type: text/plain, Size: 795 bytes --]
diff --git a/sound/mips/au1x00.c b/sound/mips/au1x00.c
index 6d8f8b3..aa9c5d5 100644
--- a/sound/mips/au1x00.c
+++ b/sound/mips/au1x00.c
@@ -561,12 +561,13 @@ snd_au1000_ac97_new(struct snd_au1000 *a
.read = snd_au1000_ac97_read,
};
- if ((au1000->ac97_res_port = request_region(AC97C_CONFIG,
- sizeof(struct au1000_ac97_reg), "Au1x00 AC97")) == NULL) {
+ if ((au1000->ac97_res_port = request_mem_region(CPHYSADDR(AC97C_CONFIG),
+ 0x100000, "Au1x00 AC97")) == NULL) {
snd_printk(KERN_ERR "ALSA AC97: can't grap AC97 port\n");
return -EBUSY;
}
- au1000->ac97_ioport = (struct au1000_ac97_reg *) au1000->ac97_res_port->start;
+ au1000->ac97_ioport = (struct au1000_ac97_reg *)
+ KSEG1ADDR(au1000->ac97_res_port->start);
spin_lock_init(&au1000->ac97_lock);
next reply other threads:[~2006-03-20 21:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-20 21:17 Sergei Shtylylov [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-03-21 1:01 [PATCH] AMD Au1x00: AC'97 controller is memory mapped Sergei Shtylylov
2006-03-21 12:00 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=441F1BEE.8080307@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=alsa-devel@lists.sourceforge.net \
--cc=jordan.crouse@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.