From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792434014; b=qIcCxshWE1mQQDBG+BfEGLlHD0FbqhrktvVUEH6by0NvAsjMaZYdcQRpl+hqJxVJhVCk ekB6o68wqW929pTWl8sh5yFVOEBgPAjnpAdl445OY6SOvvLi9nZUs8ZY8co4d1FRZcZNa sLJ9wbvXbIww1kOGkLW9RTLYOWZ+38zF3D6rq+hMrnFpstKISz12aM/rMzEAtKAEsXxUH QVr2iPEPeDe3Fv5QMIlka9RvdgbdYzlOUK5dIFo8D9aJgKZQcLyrasJYlxHB+GeuwMztB DYQIAsAILbBfnOgyPPjm0EX9ODgqO63/V/X19pjLpbKW9qxP9kvNBlUGe1DuZZ2/ejg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792434014; h=Received:DKIM-Signature:Message-ID:Date:MIME-Version:User-Agent: Subject:Content-Language:To:Cc:References:From:Autocrypt:Organization: In-Reply-To:Content-Type:Content-Transfer-Encoding; bh=QQqOO1sp1cVBMPwhmXDcJAZwgEN/7tzZ1OuMS3CEjL0=; b=l4P836V9j+AgNRG9hfATslQ+57T4T9BnxEw0CfECWNK/tpKqGvn/nrlNZVkBm9XEqmUz asCMfkc2W0LqyBxdALiYr7iAwJzH7v9GoISNZEnvOMLJr64Bse4TwTSlHPRYTMFb1FvpS 5IJUv6EQUm4nAnofRHjYjdBDsVl3gksr9b+V0IBWZ/+lh1LSXpe/m4HikqtNRsyWv6KM3 YEDL/W0Na8ZsS/Nvc4KZAQxVghEYL8ckj8ewGiiNJevgMdE13oIEVPn65H5UIiIhblb3b x37JQYvQ8b7q4fmf1FZH/VBLUeeglz0vO2v/t/oWVfzRwH91KsTzaUkJpNi9nNbY5ow== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=EMjSQbVv; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93A54606A31A; Mon, 19 Oct 2026 18:20:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=EMjSQbVv Received: by smtp.kernel.org (Postfix) with ESMTPSA id 922341F000C4; Mon, 19 Oct 2026 18:20:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1792434014; bh=QQqOO1sp1cVBMPwhmXDcJAZwgEN/7tzZ1OuMS3CEjL0=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=EMjSQbVvY9EmxNJweezjTboFtYnjHDOMkgDo/Djfay52tYMV91gvSA/+hp30T2Vgx G9pDZE3col+s8h5vTzRGh+w2CsiuEhErstSq22nOrrbrB2mET0dsRIB2cu7D2uASbK zqBlMzzB6QW6vxzqAvvIDIgZPmYjt3RfgmlojdTvwebw4Nq84vMdVRM884XD5Zsh1S iajaKcQW/dsK7HPWjv+LnDXkq+zDQsyqwUxKzSD3WUYc96sSaXJ/DJ+lKKLt53U6qI G8mSQGGB4c56Og9Axj21pon9ulsnMjOEelrG+e3JVZ8s2H9MxkVJeBaXaKunRT/dN2 RECNcwcbdIsPw== Message-ID: <441c410c-d75e-4dcf-a9eb-b246013bef7a@kernel.org> Date: Mon, 19 Oct 2026 20:20:10 +0200 X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH 6.6.y] mptcp: move the OoO check back into __mptcp_try_fallback() Content-Language: fr To: Abdul Wasey , stable@vger.kernel.org Cc: mptcp@lists.linux.dev, Mat Martineau , Geliang Tang , Paolo Abeni References: <20261019111551.2063200-1-w453y.me@gmail.com> From: Matthieu Baerts Autocrypt: addr=matttbe@kernel.org; keydata= xsFNBFXj+ekBEADxVr99p2guPcqHFeI/JcFxls6KibzyZD5TQTyfuYlzEp7C7A9swoK5iCvf YBNdx5Xl74NLSgx6y/1NiMQGuKeu+2BmtnkiGxBNanfXcnl4L4Lzz+iXBvvbtCbynnnqDDqU c7SPFMpMesgpcu1xFt0F6bcxE+0ojRtSCZ5HDElKlHJNYtD1uwY4UYVGWUGCF/+cY1YLmtfb WdNb/SFo+Mp0HItfBC12qtDIXYvbfNUGVnA5jXeWMEyYhSNktLnpDL2gBUCsdbkov5VjiOX7 CRTkX0UgNWRjyFZwThaZADEvAOo12M5uSBk7h07yJ97gqvBtcx45IsJwfUJE4hy8qZqsA62A nTRflBvp647IXAiCcwWsEgE5AXKwA3aL6dcpVR17JXJ6nwHHnslVi8WesiqzUI9sbO/hXeXw TDSB+YhErbNOxvHqCzZEnGAAFf6ges26fRVyuU119AzO40sjdLV0l6LE7GshddyazWZf0iac nEhX9NKxGnuhMu5SXmo2poIQttJuYAvTVUNwQVEx/0yY5xmiuyqvXa+XT7NKJkOZSiAPlNt6 VffjgOP62S7M9wDShUghN3F7CPOrrRsOHWO/l6I/qJdUMW+MHSFYPfYiFXoLUZyPvNVCYSgs 3oQaFhHapq1f345XBtfG3fOYp1K2wTXd4ThFraTLl8PHxCn4ywARAQABzSRNYXR0aGlldSBC YWVydHMgPG1hdHR0YmVAa2VybmVsLm9yZz7CwZEEEwEIADsCGwMFCwkIBwIGFQoJCAsCBBYC AwECHgECF4AWIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZUDpDAIZAQAKCRD2t4JPQmmgcz33 EACjROM3nj9FGclR5AlyPUbAq/txEX7E0EFQCDtdLPrjBcLAoaYJIQUV8IDCcPjZMJy2ADp7 /zSwYba2rE2C9vRgjXZJNt21mySvKnnkPbNQGkNRl3TZAinO1Ddq3fp2c/GmYaW1NWFSfOmw MvB5CJaN0UK5l0/drnaA6Hxsu62V5UnpvxWgexqDuo0wfpEeP1PEqMNzyiVPvJ8bJxgM8qoC cpXLp1Rq/jq7pbUycY8GeYw2j+FVZJHlhL0w0Zm9CFHThHxRAm1tsIPc+oTorx7haXP+nN0J iqBXVAxLK2KxrHtMygim50xk2QpUotWYfZpRRv8dMygEPIB3f1Vi5JMwP4M47NZNdpqVkHrm jvcNuLfDgf/vqUvuXs2eA2/BkIHcOuAAbsvreX1WX1rTHmx5ud3OhsWQQRVL2rt+0p1DpROI 3Ob8F78W5rKr4HYvjX2Inpy3WahAm7FzUY184OyfPO/2zadKCqg8n01mWA9PXxs84bFEV2mP VzC5j6K8U3RNA6cb9bpE5bzXut6T2gxj6j+7TsgMQFhbyH/tZgpDjWvAiPZHb3sV29t8XaOF BwzqiI2AEkiWMySiHwCCMsIH9WUH7r7vpwROko89Tk+InpEbiphPjd7qAkyJ+tNIEWd1+MlX ZPtOaFLVHhLQ3PLFLkrU3+Yi3tXqpvLE3gO3LM7BTQRV4/npARAA5+u/Sx1n9anIqcgHpA7l 5SUCP1e/qF7n5DK8LiM10gYglgY0XHOBi0S7vHppH8hrtpizx+7t5DBdPJgVtR6SilyK0/mp 9nWHDhc9rwU3KmHYgFFsnX58eEmZxz2qsIY8juFor5r7kpcM5dRR9aB+HjlOOJJgyDxcJTwM 1ey4L/79P72wuXRhMibN14SX6TZzf+/XIOrM6TsULVJEIv1+NdczQbs6pBTpEK/G2apME7vf mjTsZU26Ezn+LDMX16lHTmIJi7Hlh7eifCGGM+g/AlDV6aWKFS+sBbwy+YoS0Zc3Yz8zrdbi Kzn3kbKd+99//mysSVsHaekQYyVvO0KD2KPKBs1S/ImrBb6XecqxGy/y/3HWHdngGEY2v2IP Qox7mAPznyKyXEfG+0rrVseZSEssKmY01IsgwwbmN9ZcqUKYNhjv67WMX7tNwiVbSrGLZoqf Xlgw4aAdnIMQyTW8nE6hH/Iwqay4S2str4HZtWwyWLitk7N+e+vxuK5qto4AxtB7VdimvKUs x6kQO5F3YWcC3vCXCgPwyV8133+fIR2L81R1L1q3swaEuh95vWj6iskxeNWSTyFAVKYYVskG V+OTtB71P1XCnb6AJCW9cKpC25+zxQqD2Zy0dK3u2RuKErajKBa/YWzuSaKAOkneFxG3LJIv Hl7iqPF+JDCjB5sAEQEAAcLBXwQYAQIACQUCVeP56QIbDAAKCRD2t4JPQmmgc5VnD/9YgbCr HR1FbMbm7td54UrYvZV/i7m3dIQNXK2e+Cbv5PXf19ce3XluaE+wA8D+vnIW5mbAAiojt3Mb 6p0WJS3QzbObzHNgAp3zy/L4lXwc6WW5vnpWAzqXFHP8D9PTpqvBALbXqL06smP47JqbyQxj Xf7D2rrPeIqbYmVY9da1KzMOVf3gReazYa89zZSdVkMojfWsbq05zwYU+SCWS3NiyF6QghbW voxbFwX1i/0xRwJiX9NNbRj1huVKQuS4W7rbWA87TrVQPXUAdkyd7FRYICNW+0gddysIwPoa KrLfx3Ba6Rpx0JznbrVOtXlihjl4KV8mtOPjYDY9u+8x412xXnlGl6AC4HLu2F3ECkamY4G6 UxejX+E6vW6Xe4n7H+rEX5UFgPRdYkS1TA/X3nMen9bouxNsvIJv7C6adZmMHqu/2azX7S7I vrxxySzOw9GxjoVTuzWMKWpDGP8n71IFeOot8JuPZtJ8omz+DZel+WCNZMVdVNLPOd5frqOv mpz0VhFAlNTjU1Vy0CnuxX3AM51J8dpdNyG0S8rADh6C8AKCDOfUstpq28/6oTaQv7QZdge0 JY6dglzGKnCi/zsmp2+1w559frz4+IC7j/igvJGX4KDDKUs0mlld8J2u2sBXv7CGxdzQoHaz lzVbFe7fduHbABmYz9cefQpO7wDE/Q== Organization: NGI0 Core In-Reply-To: <20261019111551.2063200-1-w453y.me@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Abdul, On 19/10/2026 13:15, Abdul Wasey wrote: > The 6.6.y backport of upstream commit 1bba3f219c5e ("mptcp: do not > fallback when OoO is present") put the out-of-order queue check > in __mptcp_finish_join() instead of __mptcp_try_fallback(). > > So the fix itself is missing, as fallback still happens with OoO data > queued. Worse, the passive side now refuses every MP_JOIN while its > OoO queue is not empty, which is the normal state of a connection > already sending data over more than one subflow. The joining subflow > is reset, so such a connection can't add a new path, and a path that > comes back after an outage can't rejoin while data is in flight. > > Move the check to __mptcp_try_fallback(), as upstream does. On this > branch that function is in protocol.h. The fix here looks good to me, thank you! Reviewed-by: Matthieu Baerts (NGI0) Cheers, Matt -- Sponsored by the NGI0 Core fund.