All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nivedita Singhvi <niv@us.ibm.com>
To: Don Fry <brazilnut@us.ibm.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: qemu pcnet emulation problems.
Date: Tue, 21 Mar 2006 17:36:54 -0800	[thread overview]
Message-ID: <4420AA36.4020004@us.ibm.com> (raw)
In-Reply-To: <20060322010235.GA16108@us.ibm.com>

Don Fry wrote:
> There are/may be several other bugs with the qemu pcnet emulation.  I do

Not sure if Don mentioned this earlier, but for the benefit of those
who might need the context, please see Xen Bugzilla #574/#575.

> not know if there is any other serialization outside of this code, but if
> both a transmit and a receive operation were to be performed at the same
> time on different cpus, since the same buffer is used for both transmit
> and receive, that would also cause data corruption.
> 
> Does anyone else know how this is prevented, or is this another source
> of corruption?
> 
> Another thing I noticed, that will reduce throughput if corrected, is
> that the wrong bit is being examined in the receive path, to determine
> if mac level crc should be computed.  Right now, the wrong bit is being
> checked and no mac level crc is being calculated.  If the right bit were
> looked at, mac level crc would need to be computed, slowing down the
> transfers.  However, since no driver cares about the crc right now,
> since neither Linux or XP complain, could the code to compute the crc be
> deleted?  Maybe just comment that the crc should be computed.
> 
> Any recommendations?

I'd really like to continue to avoid the CRC computation between
domains, but intentionally, this time, in a clean way :).

thanks,
Nivedita

  reply	other threads:[~2006-03-22  1:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-22  1:02 qemu pcnet emulation problems Don Fry
2006-03-22  1:36 ` Nivedita Singhvi [this message]
2006-03-22  9:08   ` Keir Fraser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4420AA36.4020004@us.ibm.com \
    --to=niv@us.ibm.com \
    --cc=brazilnut@us.ibm.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.