All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Jing Min Zhao <zhaojingmin@hotmail.com>
Cc: netfilter-devel@lists.netfilter.org
Subject: Re: New H.323 conntrack & NAT helper module
Date: Wed, 22 Mar 2006 17:04:56 +0100	[thread overview]
Message-ID: <442175A8.7040103@trash.net> (raw)
In-Reply-To: <BAY109-DAV130DE7B7B14F08F39A37E1B3D90@phx.gbl>

Jing Min Zhao wrote:
> Andrew Morton found some compilation errors at the linkage stage:
> 
> LD .tmp_vmlinux1 net/built-in.o(.text+0x7762d): In function
> `set_sig_addr': : undefined reference to `get_h225_addr'
> net/built-in.o(.text+0x776c9): In function `set_sig_addr': : undefined
> reference to `get_h225_addr' net/built-in.o(.text+0x77742): In function
> `set_ras_addr': : undefined reference to `get_h225_addr'
> net/built-in.o(.text+0x77d82): In function `nat_q931': : undefined
> reference to `get_h225_addr' make: *** [.tmp_vmlinux1] Error 1
> 
> The reason is function 'get_h225_addr` is incorrectly defined as a
> 'static' function in ip_conntrack_helper_h323.c and `set_sig_addr' is in
> ip_nat_helper_h323.c. This is interesting because
> gcc normally doesn't report this obvious error.
> 
> I apologize and will release a bugfix version soon.

Don't worry, I already fixed it in my tree and will push it out
soon.

  reply	other threads:[~2006-03-22 16:04 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-25  4:00 New H.323 conntrack & NAT helper module Greg Scott
2006-02-25  6:00 ` Jing Min Zhao
2006-02-25  9:01   ` Patrick McHardy
2006-02-25 17:07     ` Jing Min Zhao
2006-02-25 18:43       ` Patrick McHardy
2006-03-01  2:57         ` Jing Min Zhao
2006-03-04  9:41           ` Patrick McHardy
2006-03-13  2:22             ` Jing Min Zhao
2006-03-13 15:00               ` Patrick McHardy
2006-03-16  2:24                 ` Jing Min Zhao
2006-03-16  8:55                   ` Patrick McHardy
2006-03-17 14:56                     ` Jing Min Zhao
2006-03-18 16:38                     ` Jing Min Zhao
2006-03-18 16:47                       ` Patrick McHardy
2006-03-18 17:13                         ` Jing Min Zhao
2006-03-20 14:22                       ` Patrick McHardy
2006-03-20 15:51                         ` Jing Min Zhao
2006-03-20 19:13                           ` Patrick McHardy
2006-03-22 14:26                             ` Jing Min Zhao
2006-03-22 16:04                               ` Patrick McHardy [this message]
2006-03-22 16:18                                 ` Jing Min Zhao
  -- strict thread matches above, loose matches on Subject: below --
2006-02-22  5:56 Jing Min Zhao
2006-02-22  6:17 ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=442175A8.7040103@trash.net \
    --to=kaber@trash.net \
    --cc=netfilter-devel@lists.netfilter.org \
    --cc=zhaojingmin@hotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.