From: Thomas Monjalon <thomas@monjalon.net>
To: Harman Kalra <hkalra@marvell.com>
Cc: stable@dpdk.org, "remy.horton@intel.com" <remy.horton@intel.com>,
"reshma.pattan@intel.com" <reshma.pattan@intel.com>,
"anatoly.burakov@intel.com" <anatoly.burakov@intel.com>,
"marko.kovacevic@intel.com" <marko.kovacevic@intel.com>,
"john.mcnamara@intel.com" <john.mcnamara@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
jerinj@marvell.com
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/2] metrics: new API to deinitialise metrics library
Date: Thu, 11 Jul 2019 00:08:09 +0200 [thread overview]
Message-ID: <4424857.lkIZ7qNV9V@xps> (raw)
In-Reply-To: <1562755934-13358-1-git-send-email-hkalra@marvell.com>
10/07/2019 12:52, Harman Kalra:
> Once the library usage is over, it must be deinitialized which
> will free the shared memory reserved during initialization.
>
> Observed an issue while running 'metrics_autotest' continuously
> without quiting. For the first run 'metrics_autotest' passes
> all test cases but second run onwards first test case fails
> because metrics library is already initialized during first run.
>
> Cc: stable@dpdk.org
>
> Signed-off-by: Harman Kalra <hkalra@marvell.com>
> ---
> v2:
> * Adding stable@dpdk.org into cc as this patch falls between bug fix
> and new feature.
> v3:
> * Fixed check-git-log.sh and make doc-guides-html issues.
Why don't you take our comments into account?
Reminder 1:
"
I was waiting for an ack on this patch,
and realized that there was one already on v1.
When sending v2, you should have reported the Ack.
"
Reminder 2:
"
Tested-by : Reshma Pattan <reshma.pattan@intel.com>
Reviewed-by: Reshma Pattan <reshma.pattan@intel.com>
Acked-by: Reshma Pattan <reshma.pattan@intel.com>
Please keep these tags for next versions.
"
Reminder 3:
"
I would vote for not backporting this new API.
"
In case it is not clear, this comment means you should not Cc stable@dpdk.org
next prev parent reply other threads:[~2019-07-10 22:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 14:45 [PATCH 1/2] metrics: new API to deinitialise metrics library Harman Kalra
2019-02-22 14:45 ` [PATCH 2/2] test/metrics: first test case fails on continuous execution Harman Kalra
2019-02-25 12:21 ` Remy Horton
2019-02-25 12:21 ` [PATCH 1/2] metrics: new API to deinitialise metrics library Remy Horton
2019-02-27 10:51 ` Harman Kalra
2019-03-01 10:07 ` [PATCH v2 " Harman Kalra
2019-03-01 10:07 ` [PATCH v2 2/2] test/metrics: first test case fails on continuous Harman Kalra
2019-06-27 10:59 ` [dpdk-dev] [PATCH v2 1/2] metrics: new API to deinitialise metrics library Pattan, Reshma
2019-06-27 11:03 ` Pattan, Reshma
2019-07-10 10:52 ` [dpdk-dev] [PATCH v3 " Harman Kalra
2019-07-10 10:52 ` [dpdk-dev] [PATCH v3 2/2] test/metrics: fix metrics autotest failure Harman Kalra
2019-07-10 22:08 ` Thomas Monjalon [this message]
2019-07-11 8:12 ` [dpdk-dev] [dpdk-stable] [PATCH v3 1/2] metrics: new API to deinitialise metrics library Harman Kalra
2019-07-11 8:34 ` Thomas Monjalon
2019-07-11 9:26 ` [dpdk-dev] [PATCH v4 " Harman Kalra
2019-07-11 9:26 ` [dpdk-dev] [PATCH v4 2/2] test/metrics: fix metrics autotest failure Harman Kalra
2019-07-16 10:49 ` [dpdk-dev] [PATCH v4 1/2] metrics: new API to deinitialise metrics library Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4424857.lkIZ7qNV9V@xps \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=hkalra@marvell.com \
--cc=jerinj@marvell.com \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=remy.horton@intel.com \
--cc=reshma.pattan@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.