From: Jeff Garzik <jgarzik@pobox.com>
To: Tejun Heo <htejun@gmail.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
albertcc@tw.ibm.com, linux-ide@vger.kernel.org
Subject: Re: [PATCH 1/2] libata: implement ata_dev_enabled, disabled and present()
Date: Fri, 24 Mar 2006 22:50:55 -0500 [thread overview]
Message-ID: <4424BE1F.7090305@pobox.com> (raw)
In-Reply-To: <20060325005305.GD5288@htj.dyndns.org>
Tejun Heo wrote:
> This patch renames ata_dev_present() to ata_dev_enabled() and adds
> ata_dev_disabled() and ata_dev_present(). This is to discern the
> state where a device is present but disabled from not-present state.
> This disctinction is necessary when configuring transfer mode because
> device selection timing must not be violated even if a device fails to
> configures.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
OK in general, but NAK for transition reasons: this invites silent
breakage of code not yet in #upstream, because ata_dev_present()
implementation changes but the function signature does not. If a new
ata_dev_present() is to be introduced, either a different name should be
chosen, or the function signature should change such that an older user
of the API will see a compiler warning or error.
Jeff
next prev parent reply other threads:[~2006-03-25 3:51 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-24 6:25 [PATCHSET] libata: add @disable_on_err to ata_set_mode(), take#2 Tejun Heo
2006-03-24 6:25 ` [PATCH 1/5] libata: check if port is disabled after internal command Tejun Heo
2006-03-24 14:40 ` Jeff Garzik
2006-03-24 6:25 ` [PATCH 2/5] libata: implement ata_dev_disable() Tejun Heo
2006-03-24 6:25 ` [PATCH 4/5] libata: make ata_set_mode() responsible for failure handling Tejun Heo
2006-03-24 6:25 ` [PATCH 5/5] libata: add @disable_on_err argument to ata_set_mode() Tejun Heo
2006-03-24 15:04 ` Jeff Garzik
2006-03-24 15:51 ` Alan Cox
2006-03-25 0:53 ` [PATCH 1/2] libata: implement ata_dev_enabled, disabled and present() Tejun Heo
2006-03-25 3:50 ` Jeff Garzik [this message]
2006-03-25 1:14 ` [PATCH 2/2] libata: add @disable_on_err argument to ata_set_mode() Tejun Heo
2006-03-25 4:03 ` Jeff Garzik
2006-03-25 5:40 ` Tejun Heo
2006-03-25 6:12 ` [PATCH 1/2] libata: implement ata_dev_enabled and disabled() Tejun Heo
2006-03-25 23:54 ` Alan Cox
2006-03-25 23:57 ` Tejun Heo
2006-03-27 11:17 ` Alan Cox
2006-03-29 6:58 ` Tejun Heo
2006-03-29 11:59 ` Alan Cox
2006-03-30 21:59 ` Jeff Garzik
2006-03-30 23:36 ` Tejun Heo
2006-03-25 6:13 ` [PATCH 2/2] libata: add @disable_on_err argument to ata_set_mode() Tejun Heo
2006-03-25 23:58 ` Alan Cox
2006-03-24 6:25 ` [PATCH 3/5] libata: use ata_dev_disable() in ata_bus_probe() Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4424BE1F.7090305@pobox.com \
--to=jgarzik@pobox.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=albertcc@tw.ibm.com \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.