From: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "Suren Baghdasaryan" <surenb@google.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Arve Hjønnevåg" <arve@android.com>,
"Todd Kjos" <tkjos@android.com>,
"Martijn Coenen" <maco@android.com>,
"Joel Fernandes" <joel@joelfernandes.org>,
"Christian Brauner" <christian@brauner.io>,
"Hridya Valsaraju" <hridya@google.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: android: Remove set but unused variable in ashmem.c
Date: Wed, 28 Jul 2021 14:00:19 +0200 [thread overview]
Message-ID: <4425350.seJdf4cM5h@localhost.localdomain> (raw)
In-Reply-To: <20210726134454.GJ1931@kadam>
Hello Dan,
On Monday, July 26, 2021 3:44:54 PM CEST Dan Carpenter wrote:
> On Sat, Jul 24, 2021 at 09:49:35AM +0200, Fabio M. De Francesco wrote:
> >
> > [...]
> >
> Another trick which would have helped is to try find out which patch
> forgot to remove the "inode" variable, because that developer would have
> seen the warning as well.
>
> > > I'm guessing you are building with CONFIG_LOCKDEP=n.
> >
> > Actually my .config sets CONFIG_LOCKDEP_SUPPORT=y. Did you refer to this?
> > There is no CONFIG_LOCKDEP in the file.
>
> Use make nconfig and then use f8 to search for CONFIG_LOCKDEP.
>
> regards,
> dan carpenter
Thanks a lot. As always, you've been very helpful. I appreciate your
willingness to help and, more generally, your attitude towards people with
less experience than yours.
By using F8, I found that CONFIG_LOCKDEP is selected by CONFIG_LOCK_STAT (in
logical AND with other options) but, in my .config, the latter was set to 'n'.
After setting this other option to 'y', CONFIG_LOCKDEP magically :) appeared
in .config and it was automatically set to 'y'.
I see that the same kind of search can also be done by using the slash if one
uses "make menuconfig".
Regards,
Fabio
next prev parent reply other threads:[~2021-07-28 12:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-23 20:05 [PATCH] staging: android: Remove set but unused variable in ashmem.c Fabio M. De Francesco
2021-07-23 20:14 ` Suren Baghdasaryan
2021-07-24 7:49 ` Fabio M. De Francesco
2021-07-26 13:44 ` Dan Carpenter
2021-07-28 12:00 ` Fabio M. De Francesco [this message]
2021-07-24 2:53 ` kernel test robot
2021-07-24 2:53 ` kernel test robot
2021-07-24 3:14 ` kernel test robot
2021-07-24 3:14 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4425350.seJdf4cM5h@localhost.localdomain \
--to=fmdefrancesco@gmail.com \
--cc=arve@android.com \
--cc=christian@brauner.io \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=hridya@google.com \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=maco@android.com \
--cc=surenb@google.com \
--cc=tkjos@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.