From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Andrew Morton <akpm@osdl.org>
Cc: vatsa@in.ibm.com, mingo@elte.hu, suresh.b.siddha@intel.com,
pj@sgi.com, hawkes@sgi.com, linux-kernel@vger.kernel.org,
dino@in.ibm.com
Subject: Re: [PATCH 2.6.16-mm1 1/2] sched_domain: handle kmalloc failure
Date: Sun, 26 Mar 2006 13:03:03 +1000 [thread overview]
Message-ID: <44260467.10402@yahoo.com.au> (raw)
In-Reply-To: <20060325184441.0f6ba5bc.akpm@osdl.org>
Andrew Morton wrote:
> Srivatsa Vaddagiri <vatsa@in.ibm.com> wrote:
>
>>If we decide to return an error, then it has to be percolated all the
>>way down (for ex: update_cpu_domains should now have to return an error
>>too if partition_sched_domains returns an error)?
>
>
> Well, when is this code called? It would be at boot time, in which case
> the allocations will succeed (if not, the boot fails) or at cpu/node
> hot-add, in which case the appropriate response is to fail to bring up the
> new cpu/node.
>
> It's better to send the administrator back to work out why we ran out of
> memory than to appear to have brought the new cpu/node online, only to have
> it run funny.
>
> I think?
>
I agree, for bootup/hot-add.
Not so sure about exclusive cpusets.
--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com
next prev parent reply other threads:[~2006-03-26 3:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-25 8:27 [PATCH 2.6.16-mm1 1/2] sched_domain: handle kmalloc failure Srivatsa Vaddagiri
2006-03-26 2:06 ` Andrew Morton
2006-03-26 2:40 ` Srivatsa Vaddagiri
2006-03-26 2:44 ` Andrew Morton
2006-03-26 3:03 ` Nick Piggin [this message]
2006-03-26 3:38 ` Srivatsa Vaddagiri
2006-03-26 4:10 ` Paul Jackson
2006-03-26 3:32 ` Srivatsa Vaddagiri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44260467.10402@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=akpm@osdl.org \
--cc=dino@in.ibm.com \
--cc=hawkes@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=pj@sgi.com \
--cc=suresh.b.siddha@intel.com \
--cc=vatsa@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.