From: jim.cromie@gmail.com (Jim Cromie)
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] [patch 0/2] hwmon/pc87360 shrink object size by
Date: Sun, 26 Mar 2006 22:47:13 +0000 [thread overview]
Message-ID: <442719F1.8020408@gmail.com> (raw)
From: Jim Cromie <jim.cromie at gmail.com>
Heres 2 patches to shrink object size of hwmon/pc87360 driver
1. hwmon-pc87360-use-sensor-attr-2.patch
Converts SENSOR_ATTRs to SENSOR_ATTR_2s for all sysfs-callbacks.
Also adds a number of #defines which provide values used to
initialize the sensor_device_attr_2.nr field for each sensor.
2. hwmon-pc87360-sysfs-combo-callbacks.patch
This combines individual (show|set)_Sensor_Attr callbacks into
(show|set)_Sensor callbacks that handle all that Sensor's Attrs.
The callback routines use the .nr field to determine what attribute
they were called for.
Combining callbacks results in a non-trivial size reduction (b4, after)
14588 3224 16 17828 45a4 A-2/drivers/hwmon/pc87360.ko
13124 3224 16 16364 3fec A-3/drivers/hwmon/pc87360.ko
ie about 9%
Combining all show_X (for all X) together is possible, but would
compromise clarity, and would save only ~ 1/5 th additional space.
These were tested against 2.6.16 + 4 patches from -mm1
(-mm1 is panic'g at boot on this NFS-root box)
Id like to see these get into -mm2
next reply other threads:[~2006-03-26 22:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-26 22:47 Jim Cromie [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-04-07 4:09 [lm-sensors] [patch 0/2] hwmon/pc87360 shrink object size by Jim Cromie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=442719F1.8020408@gmail.com \
--to=jim.cromie@gmail.com \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.