From: Andreas Ericsson <ae@op5.se>
To: Mark Wooding <mdw@distorted.org.uk>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] xdiff: Show function names in hunk headers.
Date: Tue, 28 Mar 2006 13:07:00 +0200 [thread overview]
Message-ID: <442918D4.6070105@op5.se> (raw)
In-Reply-To: <11435126113456-git-send-email-mdw@distorted.org.uk>
Mark Wooding wrote:
>
> The function names are parsed by a particularly stupid algorithm at the
> moment: it just tries to find a line in the `old' file, from before the
> start of the hunk, whose first character looks plausible. Still, it's
> most definitely a start.
>
Stupid is sometimes good. I've noticed that the gnu diff algorithm
sometimes won't notice changes in small structs, though they are large
enough for the surrounding context in the unified diff not to show it
either.
--
Andreas Ericsson andreas.ericsson@op5.se
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231
prev parent reply other threads:[~2006-03-28 11:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-28 2:23 [PATCH] xdiff: Show function names in hunk headers Mark Wooding
2006-03-28 5:54 ` Junio C Hamano
2006-03-28 9:50 ` Junio C Hamano
2006-03-28 10:13 ` Mark Wooding
2006-03-28 15:03 ` Mark Wooding
2006-03-29 0:21 ` Junio C Hamano
2006-03-29 9:57 ` Mark Wooding
2006-03-28 11:07 ` Andreas Ericsson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=442918D4.6070105@op5.se \
--to=ae@op5.se \
--cc=git@vger.kernel.org \
--cc=mdw@distorted.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.