All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Lord <liml@rtr.ca>
To: Dan Aloni <da-x@monatomic.org>
Cc: Mark Lord <lkml@rtr.ca>,
	IDE/ATA development list <linux-ide@vger.kernel.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	Jens Axboe <axboe@suse.de>, Jeff Garzik <jgarzik@pobox.com>,
	sander@humilis.net, dror@xiv.co.il
Subject: Re: [PATCH 2.6.16] sata_mv.c :: three bug fixes
Date: Wed, 29 Mar 2006 12:37:22 -0500	[thread overview]
Message-ID: <442AC5D2.2080209@rtr.ca> (raw)
In-Reply-To: <20060329170628.GA25640@localdomain>

Dan Aloni wrote:

> The original code checks ap for NULL, are you sure it is safe to
> remove this?

"ap" is used above in the same function, long before the check for NULL,
so the checks lower down are worthless.

Cheers


  reply	other threads:[~2006-03-29 17:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-29 14:50 [PATCH 2.6.16] sata_mv.c :: three bug fixes Mark Lord
2006-03-29 17:06 ` Dan Aloni
2006-03-29 17:37   ` Mark Lord [this message]
2006-03-30  0:46 ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=442AC5D2.2080209@rtr.ca \
    --to=liml@rtr.ca \
    --cc=axboe@suse.de \
    --cc=da-x@monatomic.org \
    --cc=dror@xiv.co.il \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkml@rtr.ca \
    --cc=sander@humilis.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.