From: Jeff Garzik <jeff@garzik.org>
To: Linas Vepstas <linas@austin.ibm.com>
Cc: tsbogend@alpha.franken.de, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, jklewis@us.bm.com,
linuxppc-dev@ozlabs.org, donf@us.ibm.com
Subject: Re: [PATCH] Janitor: drivers/net/pcnet32: fix incorrect comments
Date: Wed, 29 Mar 2006 17:35:14 -0500 [thread overview]
Message-ID: <442B0BA2.9020200@garzik.org> (raw)
In-Reply-To: <20060328223623.GD2172@austin.ibm.com>
Linas Vepstas wrote:
> Please sign-off/ack/apply and/or forward upstream.
>
> [PATCH] Janitor: drivers/net/pcnet32: fix incorrect comments
>
> The comments concerning how the pcnet32 ethernet device driver selects
> the MAC addr to use are incorrect. A recent patch (in the last 3 months)
> changed how the code worked, but did not change the comments.
>
> Side comment: the new behaviour is good; I've got a pcnet32 card which
> powers up with garbage in the CSR's, and a good MAC addr in the PROM.
>
> Signed-off-by: Linas Vepstas <linas@linas.org>
applied
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Garzik <jeff@garzik.org>
To: Linas Vepstas <linas@austin.ibm.com>
Cc: tsbogend@alpha.franken.de, donf@us.ibm.com, jklewis@us.bm.com,
linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] Janitor: drivers/net/pcnet32: fix incorrect comments
Date: Wed, 29 Mar 2006 17:35:14 -0500 [thread overview]
Message-ID: <442B0BA2.9020200@garzik.org> (raw)
In-Reply-To: <20060328223623.GD2172@austin.ibm.com>
Linas Vepstas wrote:
> Please sign-off/ack/apply and/or forward upstream.
>
> [PATCH] Janitor: drivers/net/pcnet32: fix incorrect comments
>
> The comments concerning how the pcnet32 ethernet device driver selects
> the MAC addr to use are incorrect. A recent patch (in the last 3 months)
> changed how the code worked, but did not change the comments.
>
> Side comment: the new behaviour is good; I've got a pcnet32 card which
> powers up with garbage in the CSR's, and a good MAC addr in the PROM.
>
> Signed-off-by: Linas Vepstas <linas@linas.org>
applied
next prev parent reply other threads:[~2006-03-29 23:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-28 22:36 [PATCH] Janitor: drivers/net/pcnet32: fix incorrect comments Linas Vepstas
2006-03-28 22:36 ` Linas Vepstas
2006-03-29 22:35 ` Jeff Garzik [this message]
2006-03-29 22:35 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=442B0BA2.9020200@garzik.org \
--to=jeff@garzik.org \
--cc=donf@us.ibm.com \
--cc=jklewis@us.bm.com \
--cc=linas@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.