All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: Brian King <brking@us.ibm.com>,
	linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 1/2] scsi: Add scsi_device max_cmd_len
Date: Wed, 29 Mar 2006 18:22:09 -0500	[thread overview]
Message-ID: <442B16A1.10401@pobox.com> (raw)
In-Reply-To: <1143584967.3353.47.camel@mulgrave.il.steeleye.com>

James Bottomley wrote:
> On Tue, 2006-03-28 at 16:17 -0600, Brian King wrote:
>> Add a max_cmd_len field to the scsi_device struct
>> to allow for per device limits of allowable command
>> lengths. This will be used by libata, which is currently
>> using the max_cmd_len field in the scsi_host struct,
>> which doesn't work for attaching libata controlled
>> SATA devices to SAS HBAs.
> 
> This really doesn't look correct.  What you want is a sata transport
> class with a max command length in the host device.

Note that Tejun added an easy-to-miss ATA transport starter class in the
eh_timed_out patches.

I've always supported the additional of (and fleshing out of) an ATA 
transport class.

	Jeff



  parent reply	other threads:[~2006-03-29 23:22 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-28 22:17 [PATCH 1/2] scsi: Add scsi_device max_cmd_len Brian King
2006-03-28 22:29 ` James Bottomley
2006-03-28 22:38   ` Brian King
2006-03-28 22:49     ` James Bottomley
2006-03-29  0:03       ` Brian King
2006-03-29  0:12         ` James Bottomley
2006-03-29  4:42           ` Brian King
2006-03-29 23:22   ` Jeff Garzik [this message]
2006-03-29  9:11 ` Christoph Hellwig
2006-03-29 14:15   ` Brian King
2006-03-29 15:05     ` Christoph Hellwig
2006-03-29 23:19   ` Jeff Garzik
2006-03-30 16:39     ` Brian King
2006-03-30 16:42       ` Brian King
2006-04-04  9:25       ` Jeff Garzik
2006-04-07 13:36         ` Brian King
2006-04-01 10:31     ` Stefan Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=442B16A1.10401@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=James.Bottomley@SteelEye.com \
    --cc=brking@us.ibm.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.