From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Luke Yang <luke.adi@gmail.com>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
Nick Piggin <npiggin@suse.de>
Subject: Re: [PATCH] nommu page refcount bug fixing
Date: Thu, 30 Mar 2006 14:22:19 +1100 [thread overview]
Message-ID: <442B4EEB.6020407@yahoo.com.au> (raw)
In-Reply-To: <489ecd0c0603291905m7ebffff2j83809cc3c93595f1@mail.gmail.com>
Luke Yang wrote:
>Hi all,
>
> The previous "nommu use compound pages" patch has a problem: when
>the pages allocated is not compound page (eg: slab allocator), the
>refcount value of every page still need to be set, otherwise the
>get/put_page() would free a single page improperly, such as in
>access_process_vm().
>
>
Yep, sorry this slipped into the kernel. It's my fault for not giving
Andrew a fix for it.
As you might know, page refcounting in nommu was already broken, so
I'm working on a proper solution to fix it.
In the meantime though, this is a step backwards and reintroduces
NOMMU special-casing in page refcounting. As a temporary fix, what I
think should happen is simply for all slab allocations to ask for
__GFP_COMP pages.
Could you check that fixes your problem?
Thanks,
Nick
--
Send instant messages to your online friends http://au.messenger.yahoo.com
next prev parent reply other threads:[~2006-03-30 6:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-30 3:05 [PATCH] nommu page refcount bug fixing Luke Yang
2006-03-30 3:22 ` Nick Piggin [this message]
2006-03-30 8:56 ` Luke Yang
2006-03-30 9:00 ` Luke Yang
2006-03-30 9:07 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=442B4EEB.6020407@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luke.adi@gmail.com \
--cc=npiggin@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.