All of lore.kernel.org
 help / color / mirror / Atom feed
From: Badari Pulavarty <pbadari@us.ibm.com>
To: Nathan Scott <nathans@sgi.com>
Cc: Ralf Hildebrandt <Ralf.Hildebrandt@charite.de>,
	lkml <linux-kernel@vger.kernel.org>,
	linux-xfs@oss.sgi.com
Subject: Re: kernel BUG at fs/direct-io.c:916!
Date: Thu, 30 Mar 2006 10:42:23 -0800	[thread overview]
Message-ID: <442C268F.7080701@us.ibm.com> (raw)
In-Reply-To: 20060329082345.G871924@wobbly.melbourne.sgi.com



Nathan Scott wrote:

>On Tue, Mar 28, 2006 at 09:30:44AM -0800, Badari Pulavarty wrote:
>
>>Thanks for working this out. You may want to add a description
>>to the patch. Like:
>>
>>"inode->i_blkbits should be used instead of dio->blkbits, as
>>it may not indicate the filesystem block size all the time".
>>
>
>Will do, thanks.  Oh, another thing - what is the situation
>where a NULL bdev would be passed into __blockdev_direct_IO?
>All the filesystems seem to pass i_sb->s_bdev, so I guess it
>must be blkdev_direct_IO - can I_BDEV(inode) ever be NULL on
>a block device inode (doesn't sound right)?  If it cannot, I
>suppose we should remove those NULL bdev checks too...
>
>cheers.
>

I can't think of a case, where we would end up getting b_dev = NULL in 
direct
IO code.

Thanks,
Badari

>
>




      reply	other threads:[~2006-03-30 18:42 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-26 18:04 kernel BUG at fs/direct-io.c:916! Ralf Hildebrandt
2006-03-26 18:46 ` Ralf Hildebrandt
2006-03-26 22:08   ` Nathan Scott
2006-03-26 23:03     ` Ralf Hildebrandt
2006-03-27  5:33       ` Nathan Scott
     [not found]       ` <20060327060436.GC2481@frodo>
     [not found]         ` <20060327110342.GX21946@charite.de>
2006-03-28  5:01           ` Nathan Scott
2006-03-28 11:28             ` Ralf Hildebrandt
2006-03-28 21:43               ` Nathan Scott
2006-03-29  8:35                 ` Ralf Hildebrandt
2006-03-28 17:30             ` Badari Pulavarty
2006-03-28 22:23               ` Nathan Scott
2006-03-30 18:42                 ` Badari Pulavarty [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=442C268F.7080701@us.ibm.com \
    --to=pbadari@us.ibm.com \
    --cc=Ralf.Hildebrandt@charite.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-xfs@oss.sgi.com \
    --cc=nathans@sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.