From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Valentan Subject: Re: [PATCH] vnet-module Date: Fri, 31 Mar 2006 17:05:44 +0200 Message-ID: <442D4548.5020602@solid-soft.at> References: <442D3512.3040308@solid-soft.at> <442D400C.4030803@hpl.hp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <442D400C.4030803@hpl.hp.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Mike Wray Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org Mike Wray schrieb: > Robert Valentan wrote: > >> patch_vnet_1 >> Replacing the socketcall with direct calling the needed >> functions (my patch from 28.3) > > > I don't like the idea of pasting all this code copied from elsewhere in > the kernel. > If the problem is that __ARCH_WANT_SYS_SOCKETCALL is not defined, so > there is no socketcall, then a better solution needs to be found. x86_64 definies __ARCH_WANT_SYS_SOCKETCALL, but has no entry-point for it. A better solution will be an export of the needed functions in net/socket.c ... But where to get it ? > In the worst case a copy of the relevant bits of socket.c defining > socketcall > in a separate file with an #ifndef __ARCH_WANT_SYS_SOCKETCALL round it. I havn't take a separate file, because my solution will also work for the other systems. If you want a separate file, i will modify my patch, but we need a permanent include, or need to use "__NR_socketcall".. >> patch_vnet_2 >> Modify the module-parameter for kernel 2.6.* (the old one >> will not compile with the actual kernel 2.6.16) >> Exporting the default-values of the parameters in /sys/module >> >> patch_vnet_3 >> Some "extentions" to error-messages to identify the position >> in the code. >> I had searched a bug, but it was a wrong vnet-id ;-/ >> A hint for docu: using "123459" as vnet-id has not 4 digits >> and will be punished with errors ;-) > > The changes to the print functions are not needed - the debug macros > in the code already include the function name. All you need to do > is #define DEBUG 1. Check libxutil/debug.h. for the definitions. Ohh.. thank you for the hint ;-/ -- wbr Robert Valentan