From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: linux-mips@linux-mips.org
Cc: Jordan Crouse <jordan.crouse@amd.com>,
Manish Lachwani <mlachwani@mvista.com>
Subject: [PATCH] Au1550: make OSS drivers look pretty on loading
Date: Sat, 01 Apr 2006 01:20:36 +0400 [thread overview]
Message-ID: <442D9D24.4010507@ru.mvista.com> (raw)
In-Reply-To: <4427A31F.9080801@ru.mvista.com>
[-- Attachment #1: Type: text/plain, Size: 140 bytes --]
Hello.
Calls to pr_info() without newlines caused the OSS drivers' load time
messages to be printed w/o any spacing...
WBR, Sergei
[-- Attachment #2: Au1550-OSS-print-newlines.patch --]
[-- Type: text/plain, Size: 1405 bytes --]
diff --git a/sound/oss/au1550_ac97.c b/sound/oss/au1550_ac97.c
index f38e082..0ca90a0 100644
--- a/sound/oss/au1550_ac97.c
+++ b/sound/oss/au1550_ac97.c
@@ -1950,7 +1950,7 @@ au1550_probe(void)
goto err_dma2;
}
- pr_info("DAC: DMA%d, ADC: DMA%d", DBDMA_AC97_TX_CHAN, DBDMA_AC97_RX_CHAN);
+ pr_info("DAC: DMA%d, ADC: DMA%d\n", DBDMA_AC97_TX_CHAN, DBDMA_AC97_RX_CHAN);
/* register devices */
@@ -2031,7 +2031,7 @@ au1550_probe(void)
s->codec_base_caps = rdcodec(s->codec, AC97_RESET);
s->codec_ext_caps = rdcodec(s->codec, AC97_EXTENDED_ID);
- pr_info("AC'97 Base/Extended ID = %04x/%04x",
+ pr_info("AC'97 Base/Extended ID = %04x/%04x\n",
s->codec_base_caps, s->codec_ext_caps);
if (!(s->codec_ext_caps & AC97_EXTID_VRA)) {
@@ -2047,7 +2047,7 @@ au1550_probe(void)
s->no_vra = 1;
}
if (s->no_vra)
- pr_info("no VRA, interpolating and decimating");
+ pr_info("no VRA, interpolating and decimating\n");
/* set mic to be the recording source */
val = SOUND_MASK_MIC;
diff --git a/sound/oss/au1550_i2s.c b/sound/oss/au1550_i2s.c
index 529b625..9907ac0 100644
--- a/sound/oss/au1550_i2s.c
+++ b/sound/oss/au1550_i2s.c
@@ -1897,7 +1897,7 @@ au1550_probe(void)
goto err_dma2;
}
- pr_info("DAC: DMA%d, ADC: DMA%d", DBDMA_I2S_TX_CHAN, DBDMA_I2S_RX_CHAN);
+ pr_info("DAC: DMA%d, ADC: DMA%d\n", DBDMA_I2S_TX_CHAN, DBDMA_I2S_RX_CHAN);
/* register devices */
next prev parent reply other threads:[~2006-03-31 21:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-27 7:43 [PATCH] small time list process error in prom_getenv() Freddy Spierenburg
2006-03-27 8:32 ` Sergei Shtylylov
2006-03-27 18:44 ` [PATCH] Au1xx0: fix prom_getenv() to handle YAMON style environment Sergei Shtylylov
2006-03-28 14:54 ` [PATCH] rtc.h: fixes to make genrtc.c compilable Ralf Rösch
2006-03-28 15:12 ` Ralf Rösch
2006-03-28 15:14 ` Sergei Shtylylov
2006-03-30 15:02 ` [PATCH] small time list process error in prom_getenv() Sergei Shtylyov
2006-03-31 21:20 ` Sergei Shtylyov [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-04-02 16:25 [PATCH] Au1550: make OSS drivers look pretty on loading Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=442D9D24.4010507@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=jordan.crouse@amd.com \
--cc=linux-mips@linux-mips.org \
--cc=mlachwani@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.