From: Ben Thomas <bthomas@virtualiron.com>
To: xen-devel@lists.xensource.com
Subject: [PATCH] - Makefiles for tools/loader/{hvmloader|vmxassist}
Date: Fri, 31 Mar 2006 16:24:33 -0500 [thread overview]
Message-ID: <442D9E11.1040406@virtualiron.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 864 bytes --]
Fix makefiles for hvmloader and vmxassist for FC5 on x86_64
systems.
In FC5, gcc has issues with the command lines used to build
hvmloader and vmxassist. Basically, the compiler doesn't
like the combination of -m64 and -m32. As these are 32 bit
apps, and intended to be, take a modified approach and simply
define XEN_TARGET_ARCH for 32 bits. This cleans up the
command line and builds the images correctly.
We could also wait for a gcc fix, but...
Signed-off-by: Ben Thomas (ben@virtualiron.com)
--
------------------------------------------------------------------------
Ben Thomas Virtual Iron Software
bthomas@virtualiron.com Tower 1, Floor 2
978-849-1214 900 Chelmsford Street
Lowell, MA 01851
[-- Attachment #2: m.patch --]
[-- Type: text/x-patch, Size: 1280 bytes --]
diff -r 6730b42c7289 tools/firmware/hvmloader/Makefile
--- a/tools/firmware/hvmloader/Makefile Fri Mar 31 14:28:59 2006 -0500
+++ b/tools/firmware/hvmloader/Makefile Fri Mar 31 15:58:44 2006 -0500
@@ -21,6 +21,7 @@
# External CFLAGS can do more harm than good.
CFLAGS :=
+XEN_TARGET_ARCH = x86_32
XEN_ROOT = ../../..
include $(XEN_ROOT)/Config.mk
@@ -39,7 +40,6 @@ CFLAGS += $(call test-gcc-flag,$(CC),-f
OBJCOPY = objcopy
CFLAGS += $(DEFINES) -I. $(XENINC) -Wall -fno-builtin -O2 -msoft-float
-CFLAGS += -m32 -march=i686
LDFLAGS = -m32 -nostdlib -Wl,-N -Wl,-Ttext -Wl,$(LOADADDR)
all: hvmloader
diff -r 6730b42c7289 tools/firmware/vmxassist/Makefile
--- a/tools/firmware/vmxassist/Makefile Fri Mar 31 14:28:59 2006 -0500
+++ b/tools/firmware/vmxassist/Makefile Fri Mar 31 15:58:44 2006 -0500
@@ -21,6 +21,7 @@
# External CFLAGS can do more harm than good.
CFLAGS :=
+XEN_TARGET_ARCH = x86_32
XEN_ROOT = ../../..
include $(XEN_ROOT)/Config.mk
@@ -38,7 +39,6 @@ CPP = cpp -P
CPP = cpp -P
OBJCOPY = objcopy -p -O binary -R .note -R .comment -R .bss -S --gap-fill=0
CFLAGS += $(DEFINES) -I. $(XENINC) -Wall -fno-builtin -O2 -msoft-float
-CFLAGS += -m32 -march=i686
LDFLAGS = -m elf_i386
OBJECTS = head.o trap.o vm86.o setup.o util.o
[-- Attachment #3: Type: text/plain, Size: 138 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
next reply other threads:[~2006-03-31 21:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-31 21:24 Ben Thomas [this message]
2006-04-01 9:03 ` [PATCH] - Makefiles for tools/loader/{hvmloader|vmxassist} Keir Fraser
2006-04-01 11:12 ` Ben Thomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=442D9E11.1040406@virtualiron.com \
--to=bthomas@virtualiron.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.