From: Jeff Garzik <jeff@garzik.org>
To: Christoph Hellwig <hch@lst.de>
Cc: jejb@steeleye.com, linux-scsi@vger.kernel.org,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>
Subject: Re: [PATCH] move ->eh_strategy_handler to the transport class
Date: Sat, 01 Apr 2006 13:10:28 -0500 [thread overview]
Message-ID: <442EC214.1040303@garzik.org> (raw)
In-Reply-To: <20060401172104.GA16921@lst.de>
Christoph Hellwig wrote:
> Overriding the whole EH code is a per-transport, not per-host thing.
> Move ->eh_strategy_handler to the transport class, same as
> ->eh_timed_out.
>
> Downside is that scsi_host_alloc can't check for the total lack of EH
> anymore, but the transition period from old EH where we needed it is
> long gone already.
>
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks OK to me. I agree the transport the better place for
eh_strategy_handler.
I would prefer to merge it through the libata-dev queue, since -- as a
glance through the recent kernel changelog shows -- Tejun Heo has been
ripping through this part of libata as well.
Jeff
next prev parent reply other threads:[~2006-04-01 18:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-01 17:21 [PATCH] move ->eh_strategy_handler to the transport class Christoph Hellwig
2006-04-01 17:56 ` Arjan van de Ven
2006-04-01 19:58 ` Stefan Richter
2006-04-01 20:16 ` Jeff Garzik
2006-04-01 20:57 ` Arjan van de Ven
2006-04-01 18:10 ` Jeff Garzik [this message]
2006-04-01 19:23 ` James Bottomley
2006-04-01 19:27 ` Jeff Garzik
2006-04-03 10:44 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=442EC214.1040303@garzik.org \
--to=jeff@garzik.org \
--cc=hch@lst.de \
--cc=jejb@steeleye.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.