All of lore.kernel.org
 help / color / mirror / Atom feed
From: r.marek@sh.cvut.cz (Rudolf Marek)
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] [PATCH] remove the fix_hstcfg from i2c-piix4
Date: Sun, 02 Apr 2006 11:48:55 +0000	[thread overview]
Message-ID: <442FBA27.3080005@sh.cvut.cz> (raw)
In-Reply-To: <442F00B8.6010507@sh.cvut.cz>

Hi Jean
>>+If you have some rather strange SMBus problems, you may need to change the
>>+SMBus Interrupt Select register as it is known solution for Force CPCI735
>>+motherboard or other OSB4 based systems. Please contact us for further
>>+assistance (lm-sensors at lm-sensors.org).
> 
> 
> Oh, no. We don't want more support requests on this. Instead, please
> explain how to get the register value using lspci and how to write back
> the modified value using setpci.

Well I think there will be requests like same probability that you capture your
very own neutrino :)

Anyway I will prepare the DIY guide.

> 
> Besides, are you sure that other OSB4 based systems did need this? I've
> searched all my mails, and couldn't find anyone reporting success after
> using fix_hstcfg, except Tom.
> 

The old text suggest this. All I think is that the bios left the controller in
interrupt mode and I think our driver assumes always the SMI mode.


> 
>>-	if ((temp & 0x0E) = 8)
>>+	if (((temp & 0x0E) = 8) || ((temp & 0x0E) = 2))
> 
> 
> I think I understand that 8 is OK for non-Serverworks one and 2 is OK
> for Serverworks one, right? So maybe we can improve this check and do:
> 
> if ((temp & 0x0E) = (id->vendor = PCI_VENDOR_ID_SERVERWORKS ? 2 : 8))

I thought about this but for the reason that serverworks was bought by broadcom
and we have ATI and others there so best sounds to me to make it more global.

Regards
Rudolf




  parent reply	other threads:[~2006-04-02 11:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-01 22:37 [lm-sensors] [PATCH] remove the fix_hstcfg from i2c-piix4 Rudolf Marek
2006-04-02 11:42 ` Jean Delvare
2006-04-02 11:48 ` Rudolf Marek [this message]
2006-04-02 16:38 ` [lm-sensors] [PATCH] remove the fix_hstcfg from i2c-piix4 - Rudolf Marek
2006-04-02 21:15 ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=442FBA27.3080005@sh.cvut.cz \
    --to=r.marek@sh.cvut.cz \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.