Patch to xm create search domU config in /etc/xen/auto

Patch to xm create search domU config in /etc/xen/auto

[Itamar Reis Peixoto]

[-- Attachment #1.1: Type: text/plain, Size: 11 bytes --]

attached.

[-- Attachment #1.2: Type: text/html, Size: 374 bytes --]

[-- Attachment #2: xm-create.patch --]
[-- Type: application/octet-stream, Size: 454 bytes --]

--- ./tools/python/xen/xm/create.py     2006-04-01 19:49:34.000000000 -0500
+++ /root/xensource/create.py   2006-04-03 11:13:01.000000000 -0400
@@ -65,7 +65,7 @@
           use="Quiet.")

 gopts.opt('path', val='PATH',
-          fn=set_value, default='.:/etc/xen',
+          fn=set_value, default='.:/etc/xen:/etc/xen/auto',
           use="""Search path for configuration scripts.
          The value of PATH is a colon-separated directory list.""")


[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: Patch to xm create search domU config in /etc/xen/auto

[Anthony Liguori]

Hope this doesn't appear to be singling you out, but this is a good 
opportunity to highlight some patch submitting good practices:

1) Your patch doesn't contain a Signed-off-by line so it cannot be applied.

2) Your patch is attached with an improper MIME type.  If you cannot use 
a more sane mailer, you should also inline your patches (it's impossible 
for me to actually comment on your patch in a note without some nasty 
copy-paste stuff).

3) You include no explanation of why your patch is needed.  It seems 
somewhat arbitrary to add /etc/xen/auto to the default search path.  Why 
do you need this and why do you think other people would need this?

4) Your patch is based at a weird location (within tools/).  It's 
usually best to patch at the top of the repository (diff -u 
a/tools/xen/xm/create.py b/tools/....).  Actually, if you just use hg 
export, it'll do the right thing for you.

Please resubmit with the appropriate corrections.

Thanks!

Regards,

Anthony Liguori

Itamar Reis Peixoto wrote:
> attached.
>  
> ------------------------------------------------------------------------
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
>   

Re: Patch to xm create search domU config in /etc/xen/auto

[Itamar Reis Peixoto]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 693 bytes --]

this is a very small patch, Can you fix, aplly  and send for me ?

I will send patches correctly next time, I am sorry

this  patch include /etc/xen/auto in search path when creating a domU

domU configs can be stored in

* /etc/xen
* /etc/xen/auto - when dom0 is rebooted all domU´s with config file is 
stored in  this directory is automatic started by /etc/init.d/xendomains

when I run xm create the xm search for domU config only in
* current directory
* /etc/xen

with this patch xm will search in

* current directory
* /etc/xen
* /etc/xen/auto

without this patch to start a domU I need to run

xm create /etc/xen/auto/mydomU

with this patch I can start a domU with

xm create mydomU

Re: Patch to xm create search domU config in /etc/xen/auto

[Anthony Liguori]

Itamar Reis Peixoto wrote:
> this is a very small patch, Can you fix, aplly  and send for me ?
>   

The DCO process *requires* that you add a Signed-off-by line.  You have 
to do it, no one else can.

It's up to Ewan to decide whether it should be applied after that as he 
maintains Xend.  You also should add [PATCH] to your subject line when 
you resend it to make sure he sees it.

I don't think adding the additional search path is useful as it's 
specific xendomains (which is somewhat independent on Xend).  I think a 
more compelling approach would be to use an environmental variable as a 
search path so that you could appropriately set it in your environment.

Regards,

Anthony Liguori

> I will send patches correctly next time, I am sorry
>
> this  patch include /etc/xen/auto in search path when creating a domU
>
> domU configs can be stored in
>
> * /etc/xen
> * /etc/xen/auto - when dom0 is rebooted all domU´s with config file is 
> stored in  this directory is automatic started by /etc/init.d/xendomains
>
> when I run xm create the xm search for domU config only in
> * current directory
> * /etc/xen
>
> with this patch xm will search in
>
> * current directory
> * /etc/xen
> * /etc/xen/auto
>
> without this patch to start a domU I need to run
>
> xm create /etc/xen/auto/mydomU
>
> with this patch I can start a domU with
>
> xm create mydomU
>
>
>   

Re: Patch to xm create search domU config in /etc/xen/auto

[Molle Bestefich]

Itamar Reis Peixoto wrote:
> this  patch include /etc/xen/auto in search path when creating a domU
>
> domU configs can be stored in
>
> * /etc/xen
> * /etc/xen/auto - when dom0 is rebooted all domU´s with config file is
> stored in  this directory is automatic started by /etc/init.d/xendomains
>
> when I run xm create the xm search for domU config only in
> * current directory
> * /etc/xen

[snip]
> without this patch to start a domU I need to run
>
> xm create /etc/xen/auto/mydomU
>
> with this patch I can start a domU with
>
> xm create mydomU

What's preventing you from storing all your domU configurations in /etc/xen?

You can link to them if you want them started automatically:
# cd /etc/xen
# ln -s mydomU auto/mydomU

?
That way you can still start them with
# xm create mydomU

Also makes it easier to stop a domain from starting automatically
without nuking the domain configuration:
# rm /etc/xen/auto/mydomU

Re: Re: Patch to xm create search domU config in /etc/xen/auto

[Mark Williamson]

> What's preventing you from storing all your domU configurations in
> /etc/xen?
>
> You can link to them if you want them started automatically:
> # cd /etc/xen
> # ln -s mydomU auto/mydomU

This is the way I envisioned people using the auto directory.

> Also makes it easier to stop a domain from starting automatically
> without nuking the domain configuration:
> # rm /etc/xen/auto/mydomU

And that's why ;-)

I'd suggest just using the symlink approach rather than extending xm...  But I 
don't really think either way matters that much.

Cheers,
Mark

-- 
Dave: Just a question. What use is a unicyle with no seat?  And no pedals!
Mark: To answer a question with a question: What use is a skateboard?
Dave: Skateboards have wheels.
Mark: My wheel has a wheel!