From: Patrick McHardy <kaber@trash.net>
To: Harald Welte <laforge@netfilter.org>
Cc: netfilter-devel@lists.netfilter.org,
Stephen Hemminger <shemminger@osdl.org>
Subject: Re: [PATCH] ip_conntrack section mismatch warning fix
Date: Wed, 05 Apr 2006 17:28:24 +0200 [thread overview]
Message-ID: <4433E218.3060100@trash.net> (raw)
In-Reply-To: <20060405152306.GG20558@sunbeam.de.gnumonks.org>
Harald Welte wrote:
> On Wed, Apr 05, 2006 at 04:30:46PM +0200, Patrick McHardy wrote:
>
>>I think this might still fail without forced inlining. Our init
>>functions look like crap anyway, and the reason mostly seems to
>>be mass-registration of hooks, so I guess I'll clean that up
>>with a small helper function and then just split them.
>
>
> still I actually think of the shared init/cleanup functions as a big
> feature rather than something that needs to be 'cleaned up'.
I think they make the cleanup code quite unreadable because the
heavy mix with labels. I'm already half way through and the
seperated cleanup functions really are a lot more readable.
Besides that the split also allows to throw the init part away
after initializing, so it makes the binary smaller.
prev parent reply other threads:[~2006-04-05 15:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-04 18:32 [PATCH] ip_conntrack section mismatch warning fix Stephen Hemminger
2006-04-05 14:30 ` Patrick McHardy
2006-04-05 15:23 ` Harald Welte
2006-04-05 15:28 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4433E218.3060100@trash.net \
--to=kaber@trash.net \
--cc=laforge@netfilter.org \
--cc=netfilter-devel@lists.netfilter.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.