From: Daniel Phillips <phillips@google.com>
To: Jeff Dike <jdike@addtoit.com>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org,
user-mode-linux-devel@lists.sourceforge.net
Subject: Re: [uml-devel] Re: [PATCH 12/16] UML - Memory hotplug
Date: Wed, 05 Apr 2006 20:42:00 -0700 [thread overview]
Message-ID: <44348E08.1050502@google.com> (raw)
In-Reply-To: <20060406015636.GE6924@ccure.user-mode-linux.org>
Jeff Dike wrote:
> Yeah, it's a bit non-obvious what 0 means in the twisty little maze of
> GFP_ flags.
>
> However, I do want to push the system into reclaim later. It looks
> like the only difference between 0 and GFP_ATOMIC is the use of
> emergency pools, which I don't really want to exercise anyway.
>
> ...This look OK to you?...
>
> + /* 0 means don't wait (like GFP_ATOMIC) and
> + * don't dip into emergency pools (unlike
> + * GFP_ATOMIC).
> + */
> + new = kmalloc(sizeof(*new), 0);
If you have a believable use for gfp_mask=0 then why not add GFP_NOWAIT or some
such to gfp.h?
Regards,
Daniel
-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Phillips <phillips@google.com>
To: Jeff Dike <jdike@addtoit.com>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org,
user-mode-linux-devel@lists.sourceforge.net
Subject: Re: [uml-devel] Re: [PATCH 12/16] UML - Memory hotplug
Date: Wed, 05 Apr 2006 20:42:00 -0700 [thread overview]
Message-ID: <44348E08.1050502@google.com> (raw)
In-Reply-To: <20060406015636.GE6924@ccure.user-mode-linux.org>
Jeff Dike wrote:
> Yeah, it's a bit non-obvious what 0 means in the twisty little maze of
> GFP_ flags.
>
> However, I do want to push the system into reclaim later. It looks
> like the only difference between 0 and GFP_ATOMIC is the use of
> emergency pools, which I don't really want to exercise anyway.
>
> ...This look OK to you?...
>
> + /* 0 means don't wait (like GFP_ATOMIC) and
> + * don't dip into emergency pools (unlike
> + * GFP_ATOMIC).
> + */
> + new = kmalloc(sizeof(*new), 0);
If you have a believable use for gfp_mask=0 then why not add GFP_NOWAIT or some
such to gfp.h?
Regards,
Daniel
next prev parent reply other threads:[~2006-04-06 3:42 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-24 18:14 [uml-devel] [PATCH 12/16] UML - Memory hotplug Jeff Dike
2006-03-24 18:14 ` Jeff Dike
2006-03-24 22:45 ` [uml-devel] " Andrew Morton
2006-03-24 22:45 ` Andrew Morton
2006-03-24 23:58 ` [uml-devel] " Blaisorblade
2006-03-24 23:58 ` Blaisorblade
2006-03-25 1:19 ` Jeff Dike
2006-03-25 1:19 ` Jeff Dike
2006-03-25 1:05 ` Jeff Dike
2006-03-25 1:05 ` Jeff Dike
2006-04-05 22:02 ` [uml-devel] " Daniel Phillips
2006-04-05 22:02 ` Daniel Phillips
2006-04-06 1:56 ` [uml-devel] " Jeff Dike
2006-04-06 1:56 ` Jeff Dike
2006-04-06 3:32 ` Andrew Morton
2006-04-06 3:32 ` Andrew Morton
2006-04-06 3:33 ` Andrew Morton
2006-04-06 3:33 ` Andrew Morton
2006-04-06 3:42 ` Daniel Phillips [this message]
2006-04-06 3:42 ` Daniel Phillips
2006-03-25 19:26 ` Jan Engelhardt
2006-03-25 19:26 ` Jan Engelhardt
2006-03-25 20:08 ` [uml-devel] " Jeff Dike
2006-03-25 20:08 ` Jeff Dike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44348E08.1050502@google.com \
--to=phillips@google.com \
--cc=akpm@osdl.org \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.