Re: [PATCH] Re: Setting skb->priority with libnetfilter_queue (patch really attached this time)

[Patrick McHardy <kaber@trash.net>]

Brad Fisher wrote:
> Sorry - I got trigger happy and sent without attaching the patch... 
> Patches should be attached now.
> -Brad
> 
> Brad Fisher wrote:
> 
>> In case anyone is interested, I have written a couple of small patches
>> to accomplish what I desired.  It adds three new functions to
>> libnetfilter_queue:
>>
>>   /* Set both mark and priority */
>>   int nfq_set_verdict_mark_priority(struct nfq_q_handle *qh, u_int32_t
>> id, u_int32_t verdict, u_int32_t mark, u_int32_t priority,
>>                               u_int32_t data_len, unsigned char *buf)
>>
>>   /* Sets priority, but leaves mark unchanged */
>>   int nfq_set_verdict_priority(struct nfq_q_handle *qh, u_int32_t id,
>> u_int32_t verdict, u_int32_t priority,
>>                               u_int32_t data_len, unsigned char *buf)
>>
>>   /* Get current skb->priority value */
>>    u_int32_t nfq_get_priority(struct nfq_data *nfad)

I think allowing to set skb->priority makes sense, but I'm not entirely
happy with the 2^n nfq_set_verdict_* combinations. It would be nicer
if we had some struct representing the packet and some functions to
change nfmark, priority etc. Then we could just do
nfq_set_verdict(qh, pkt, verdict).