[Xenomai-core] Preventing kernel misconfiguration.

[Xenomai-core] Preventing kernel misconfiguration.

[Gilles Chanteperdrix]

[-- Attachment #1: message body and .signature --]
[-- Type: text/plain, Size: 165 bytes --]


Here is a patch that "selects" the I-pipe option when Xenomai is
enabled, it should help preventing kernel misconfigurations.

-- 


					    Gilles Chanteperdrix.

[-- Attachment #2: Kconfig.patch --]
[-- Type: text/plain, Size: 2169 bytes --]

Index: scripts/Kconfig.frag
===================================================================
--- scripts/Kconfig.frag	(revision 895)
+++ scripts/Kconfig.frag	(working copy)
@@ -4,7 +4,14 @@
 config XENOMAI
 	bool "Xenomai"
 	default y
+        select IPIPE
 
+        help
+          Xenomai is a real-time extension to the Linux kernel. Note 
+          that Xenomai relies on Adeos interrupt pipeline (CONFIG_IPIPE 
+          option) to be enabled, so enabling this option selects the
+          CONFIG_IPIPE option.
+
 source "arch/@LINUX_ARCH@/xenomai/Kconfig"
 
 endmenu
Index: ksrc/arch/powerpc/Config.in
===================================================================
--- ksrc/arch/powerpc/Config.in	(revision 895)
+++ ksrc/arch/powerpc/Config.in	(working copy)
@@ -1,15 +1,19 @@
 mainmenu_option next_comment
 comment 'Real-time sub-system'
 
-bool 'Xenomai' CONFIG_XENOMAI
+if [ "$CONFIG_IPIPE" = "n" ]; then
+    comment "Xenomai depends on Adeos interrupt pipeline"
+else
+    bool 'Xenomai' CONFIG_XENOMAI
 
-source kernel/xenomai/Config.in
+    source kernel/xenomai/Config.in
 
-if [ "$CONFIG_XENOMAI" = "y" -a "$CONFIG_XENO_OPT_NUCLEUS" != "n" ]; then
+    if [ "$CONFIG_XENOMAI" = "y" -a "$CONFIG_XENO_OPT_NUCLEUS" != "n" ]; then
 	mainmenu_option next_comment
 	comment 'Machine'
 	bool 'Enable FPU support' CONFIG_XENO_HW_FPU
 	endmenu
+    fi
 fi
 
 endmenu
Index: ksrc/arch/i386/Config.in
===================================================================
--- ksrc/arch/i386/Config.in	(revision 895)
+++ ksrc/arch/i386/Config.in	(working copy)
@@ -1,11 +1,14 @@
 mainmenu_option next_comment
 comment 'Real-time sub-system'
 
-bool 'Xenomai' CONFIG_XENOMAI
+if [ "$CONFIG_IPIPE" = "n" ]; then
+    comment "Xenomai depends on Adeos interrupt pipeline"
+else
+    bool 'Xenomai' CONFIG_XENOMAI
 
-source kernel/xenomai/Config.in
+    source kernel/xenomai/Config.in
 
-if [ "$CONFIG_XENOMAI" = "y" -a "$CONFIG_XENO_OPT_NUCLEUS" != "n" ]; then
+    if [ "$CONFIG_XENOMAI" = "y" -a "$CONFIG_XENO_OPT_NUCLEUS" != "n" ]; then
 
 	mainmenu_option next_comment
 	comment 'Machine'
@@ -42,6 +45,7 @@
 	fi
 	endmenu
 	endmenu
+    fi
 fi
 
 endmenu

Re: [Xenomai-core] Preventing kernel misconfiguration.

[Philippe Gerum]

Gilles Chanteperdrix wrote:
> Here is a patch that "selects" the I-pipe option when Xenomai is
> enabled, it should help preventing kernel misconfigurations.
> 

We definitely need this.

> 
> 
> ------------------------------------------------------------------------
> 
> Index: scripts/Kconfig.frag
> ===================================================================
> --- scripts/Kconfig.frag	(revision 895)
> +++ scripts/Kconfig.frag	(working copy)
> @@ -4,7 +4,14 @@
>  config XENOMAI
>  	bool "Xenomai"
>  	default y
> +        select IPIPE
>  
> +        help
> +          Xenomai is a real-time extension to the Linux kernel. Note 
> +          that Xenomai relies on Adeos interrupt pipeline (CONFIG_IPIPE 
> +          option) to be enabled, so enabling this option selects the
> +          CONFIG_IPIPE option.
> +
>  source "arch/@LINUX_ARCH@/xenomai/Kconfig"
>  
>  endmenu
> Index: ksrc/arch/powerpc/Config.in
> ===================================================================
> --- ksrc/arch/powerpc/Config.in	(revision 895)
> +++ ksrc/arch/powerpc/Config.in	(working copy)
> @@ -1,15 +1,19 @@
>  mainmenu_option next_comment
>  comment 'Real-time sub-system'
>  
> -bool 'Xenomai' CONFIG_XENOMAI
> +if [ "$CONFIG_IPIPE" = "n" ]; then
> +    comment "Xenomai depends on Adeos interrupt pipeline"
> +else
> +    bool 'Xenomai' CONFIG_XENOMAI
>  
> -source kernel/xenomai/Config.in
> +    source kernel/xenomai/Config.in
>  
> -if [ "$CONFIG_XENOMAI" = "y" -a "$CONFIG_XENO_OPT_NUCLEUS" != "n" ]; then
> +    if [ "$CONFIG_XENOMAI" = "y" -a "$CONFIG_XENO_OPT_NUCLEUS" != "n" ]; then
>  	mainmenu_option next_comment
>  	comment 'Machine'
>  	bool 'Enable FPU support' CONFIG_XENO_HW_FPU
>  	endmenu
> +    fi
>  fi
>  
>  endmenu
> Index: ksrc/arch/i386/Config.in
> ===================================================================
> --- ksrc/arch/i386/Config.in	(revision 895)
> +++ ksrc/arch/i386/Config.in	(working copy)
> @@ -1,11 +1,14 @@
>  mainmenu_option next_comment
>  comment 'Real-time sub-system'
>  
> -bool 'Xenomai' CONFIG_XENOMAI
> +if [ "$CONFIG_IPIPE" = "n" ]; then
> +    comment "Xenomai depends on Adeos interrupt pipeline"
> +else
> +    bool 'Xenomai' CONFIG_XENOMAI
>  
> -source kernel/xenomai/Config.in
> +    source kernel/xenomai/Config.in
>  
> -if [ "$CONFIG_XENOMAI" = "y" -a "$CONFIG_XENO_OPT_NUCLEUS" != "n" ]; then
> +    if [ "$CONFIG_XENOMAI" = "y" -a "$CONFIG_XENO_OPT_NUCLEUS" != "n" ]; then
>  
>  	mainmenu_option next_comment
>  	comment 'Machine'
> @@ -42,6 +45,7 @@
>  	fi
>  	endmenu
>  	endmenu
> +    fi
>  fi
>  
>  endmenu
> 


-- 

Philippe.

Re: [Xenomai-core] Preventing kernel misconfiguration.

[Jan Kiszka]

[-- Attachment #1: Type: text/plain, Size: 394 bytes --]

Philippe Gerum wrote:
> Gilles Chanteperdrix wrote:
>> Here is a patch that "selects" the I-pipe option when Xenomai is
>> enabled, it should help preventing kernel misconfigurations.
>>
> 
> We definitely need this.
> 

What about thinking further: warn in the Xenomai menu (via "comment ...
if") when problematic switches like power management are on? Just a
quick idea.

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 250 bytes --]