From: Jeff Garzik <jeff@garzik.org>
To: albertl@mail.com
Cc: linux-ide@vger.kernel.org,
Jonathan Benson <airbatica@verizon.net>,
Tejun Heo <htejun@gmail.com>,
Carlos Pardo <Carlos.Pardo@siliconimage.com>,
Doug Maxey <dwm@maxeymade.com>
Subject: Re: [PATCH/RFC] libata: turn on the ATAPI DMA DIR support per word 62
Date: Fri, 07 Apr 2006 02:47:33 -0400 [thread overview]
Message-ID: <44360B05.6050509@garzik.org> (raw)
In-Reply-To: <44360922.8050801@tw.ibm.com>
Albert Lee wrote:
> Turn on the ATAPI DMA DIR support if word 62 indicates it.
>
> Signed-off-by: Albert Lee <albertcc@tw.ibm.com>
> ---
> ATAPI DMA DIR follow-up patch to turn on the DMA_DIR support automatically
> by checking identify device word 62. (Thanks for Jeff and Tejun's pointer.)
>
> According to Jonathan's test result, SiI 3611 (the current known bridge that
> requires the ATAPI DMA DIR support) doesn't implement word 62. So, the
> atapi_dmadir parameter is preserved to enable the DMA DIR support manually as
> work around.
Two comments:
* I would like to find a device that's compliant with the spec, and test
the patch, before committing.
* DMADIR not only includes a bit flag indicating its presence, it also
moves all the DMA capability bits from their standard places. You'll
have to audit every place that reads dev->id[]'s mwdma/udma masks and
make sure they look at the DMADIR-special-case location, when DMADIR is set.
Jeff
next prev parent reply other threads:[~2006-04-07 6:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-07 2:01 libata machine check on Alpha Jonathan Benson
2006-04-07 6:18 ` Albert Lee
2006-04-07 6:39 ` [PATCH/RFC] libata: turn on the ATAPI DMA DIR support per word 62 Albert Lee
2006-04-07 6:47 ` Jeff Garzik [this message]
2006-04-07 10:21 ` Albert Lee
2006-04-07 10:46 ` [PATCH/RFC] libata: turn on the ATAPI DMADIR support per word 62 (revised) Albert Lee
2006-04-07 17:54 ` Jeff Garzik
2006-04-18 4:34 ` Albert Lee
2006-04-20 22:51 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44360B05.6050509@garzik.org \
--to=jeff@garzik.org \
--cc=Carlos.Pardo@siliconimage.com \
--cc=airbatica@verizon.net \
--cc=albertl@mail.com \
--cc=dwm@maxeymade.com \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.