From: Albert Lee <albertcc@tw.ibm.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: linux-ide@vger.kernel.org,
Jonathan Benson <airbatica@verizon.net>,
Tejun Heo <htejun@gmail.com>,
Carlos Pardo <Carlos.Pardo@siliconimage.com>,
Doug Maxey <dwm@maxeymade.com>
Subject: Re: [PATCH/RFC] libata: turn on the ATAPI DMA DIR support per word 62
Date: Fri, 07 Apr 2006 18:21:34 +0800 [thread overview]
Message-ID: <44363D2E.7010700@tw.ibm.com> (raw)
In-Reply-To: <44360B05.6050509@garzik.org>
Jeff Garzik wrote:
>
> Two comments:
>
> * I would like to find a device that's compliant with the spec, and test
> the patch, before committing.
I'm trying to get an Acard AEC-7900A and a Sunplus 3811A (which looks like
a SiI 3811 rebrand) for test. Since the DMADIR is SiImage's idea,
hopefully the Sunplus 3811A may support DMADIR. For bridges from other
vendors, I guess the chance is low.
>
> * DMADIR not only includes a bit flag indicating its presence, it also
> moves all the DMA capability bits from their standard places. You'll
> have to audit every place that reads dev->id[]'s mwdma/udma masks and
> make sure they look at the DMADIR-special-case location, when DMADIR is
> set.
>
Fortunately only ata_id_xfermask() uses the mwdma/udma bits. Revised
patch to follow. Thanks for the advice.
--
albert
next prev parent reply other threads:[~2006-04-07 10:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-07 2:01 libata machine check on Alpha Jonathan Benson
2006-04-07 6:18 ` Albert Lee
2006-04-07 6:39 ` [PATCH/RFC] libata: turn on the ATAPI DMA DIR support per word 62 Albert Lee
2006-04-07 6:47 ` Jeff Garzik
2006-04-07 10:21 ` Albert Lee [this message]
2006-04-07 10:46 ` [PATCH/RFC] libata: turn on the ATAPI DMADIR support per word 62 (revised) Albert Lee
2006-04-07 17:54 ` Jeff Garzik
2006-04-18 4:34 ` Albert Lee
2006-04-20 22:51 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44363D2E.7010700@tw.ibm.com \
--to=albertcc@tw.ibm.com \
--cc=Carlos.Pardo@siliconimage.com \
--cc=airbatica@verizon.net \
--cc=albertl@mail.com \
--cc=dwm@maxeymade.com \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.