From: Bart Samwel <bart@samwel.tk>
To: Coywolf Qi Hunt <coywolf@gmail.com>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: Re: [patch] represent-dirty__centisecs-as-jiffies-internally.patch comment fix
Date: Sat, 08 Apr 2006 19:16:08 +0200 [thread overview]
Message-ID: <4437EFD7.2070401@samwel.tk> (raw)
In-Reply-To: <2cd57c900604080310l454eec24m7298e01001f132af@mail.gmail.com>
Coywolf Qi Hunt wrote:
> 2006/3/25, akpm@osdl.org <akpm@osdl.org>:
>
>> From: Bart Samwel <bart@samwel.tk>
>>
>> Make that the internal values for:
>>
>> /proc/sys/vm/dirty_writeback_centisecs
>> /proc/sys/vm/dirty_expire_centisecs
>>
>> are stored as jiffies instead of centiseconds. Let the sysctl interface do
>> the conversions with full precision using clock_t_to_jiffies, instead of
>> doing overflow-sensitive on-the-fly conversions every time the values are
>> used.
>
>> diff -puN mm/page-writeback.c~represent-dirty__centisecs-as-jiffies-internally mm/page-writeback.c
>> --- devel/mm/page-writeback.c~represent-dirty__centisecs-as-jiffies-internally 2006-03-24 03:00:41.000000000 -0800
>> +++ devel-akpm/mm/page-writeback.c 2006-03-24 03:00:41.000000000 -0800
>> @@ -75,12 +75,12 @@ int vm_dirty_ratio = 40;
>> * The interval between `kupdate'-style writebacks, in centiseconds
>> * (hundredths of a second)
>
> Bart,
>
> You forgot to fix the comments. The attached patch fixes them.
Thanks, well spotted. I think the other patch already went into Linus'
tree, I guess this should go in there as well?
Cheers,
Bart
prev parent reply other threads:[~2006-04-08 17:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-08 10:10 [patch] represent-dirty__centisecs-as-jiffies-internally.patch comment fix Coywolf Qi Hunt
2006-04-08 17:16 ` Bart Samwel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4437EFD7.2070401@samwel.tk \
--to=bart@samwel.tk \
--cc=akpm@osdl.org \
--cc=coywolf@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.