From: Nick Piggin <nickpiggin@yahoo.com.au>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Pavel Machek <pavel@ucw.cz>,
Fabio Comolli <fabio.comolli@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: Userland swsusp failure (mm-related)
Date: Sun, 09 Apr 2006 11:51:33 +1000 [thread overview]
Message-ID: <443868A5.1020503@yahoo.com.au> (raw)
In-Reply-To: <200604090047.17372.rjw@sisk.pl>
Rafael J. Wysocki wrote:
> Hi,
>
>>>Well, it looks like we didn't free enough RAM for suspend in this case.
>>>Unfortunately we were below the min watermark for ZONE_NORMAL and
>>>we tried to allocate with GFP_ATOMIC (Nick, shouldn't we fall back to
>>>ZONE_DMA in this case?).
>>>
>>>I think we can safely ignore the watermarks in swsusp, so probably
>>>we can set PF_MEMALLOC for the current task temporarily and reset
>>>it when we have allocated memory. Pavel, what do you think?
>>
>>Seems little hacky but okay to me.
>>
>>Should not fixing "how much to free" computation to free a bit more be
>>enough to handle this?
>
>
> Yes, but in that case we'll leave some memory unused. ;-)
>
Probably doesn't fall back to ZONE_DMA because of lowmem reserve.
Yes, PF_MEMALLOC sounds like it might do what you want. A little
hackish perhaps, but better than putting swsusp special cases
into page_alloc.c.
--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com
next prev parent reply other threads:[~2006-04-09 1:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <b637ec0b0604080537s55e63544r8bb63c887e81ecaf@mail.gmail.com>
2006-04-08 15:16 ` Userland swsusp failure (mm-related) Rafael J. Wysocki
2006-04-08 16:15 ` Pavel Machek
2006-04-08 22:47 ` Rafael J. Wysocki
2006-04-08 23:24 ` Con Kolivas
2006-04-09 20:36 ` shrink_all_memory tweaks (was: Re: Userland swsusp failure (mm-related)) Rafael J. Wysocki
2006-04-09 23:23 ` Con Kolivas
2006-04-11 17:06 ` Rafael J. Wysocki
2006-04-13 12:42 ` Con Kolivas
2006-04-13 13:54 ` Rafael J. Wysocki
2006-04-13 14:01 ` Con Kolivas
2006-04-09 1:51 ` Nick Piggin [this message]
2006-04-11 21:33 ` Userland swsusp failure (mm-related) Rafael J. Wysocki
2006-04-11 21:36 ` Pavel Machek
2006-04-11 22:10 ` Rafael J. Wysocki
2006-04-12 5:29 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=443868A5.1020503@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=fabio.comolli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.