All of lore.kernel.org
 help / color / mirror / Atom feed
From: Manu Abraham <abraham.manu@gmail.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: v4l-dvb-maintainer@linuxtv.org, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] dvb/bt8xx/bt878.c: don't export static variables
Date: Sun, 09 Apr 2006 22:41:18 +0400	[thread overview]
Message-ID: <4439554E.4050200@gmail.com> (raw)
In-Reply-To: <20060409174846.GJ8454@stusta.de>

Adrian Bunk wrote:
> Static variables mustn't be EXPORT_SYMBOL'ed.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> ---
>
>  drivers/media/dvb/bt8xx/bt878.c |    2 --
>  1 file changed, 2 deletions(-)
>
> --- linux-2.6.17-rc1-mm2-full/drivers/media/dvb/bt8xx/bt878.c.old	2006-04-09 18:43:28.000000000 +0200
> +++ linux-2.6.17-rc1-mm2-full/drivers/media/dvb/bt8xx/bt878.c	2006-04-09 18:44:26.000000000 +0200
> @@ -54,26 +54,24 @@
>  static unsigned int bt878_verbose = 1;
>  static unsigned int bt878_debug;
>  
>  module_param_named(verbose, bt878_verbose, int, 0444);
>  MODULE_PARM_DESC(verbose,
>  		 "verbose startup messages, default is 1 (yes)");
>  module_param_named(debug, bt878_debug, int, 0644);
>  MODULE_PARM_DESC(debug, "Turn on/off debugging, default is 0 (off).");
>  
>  int bt878_num;
>  struct bt878 bt878[BT878_MAX];
>  
> -EXPORT_SYMBOL(bt878_debug);
> -EXPORT_SYMBOL(bt878_verbose);
>  EXPORT_SYMBOL(bt878_num);
>  EXPORT_SYMBOL(bt878);
>  
>  #define btwrite(dat,adr)    bmtwrite((dat), (bt->bt878_mem+(adr)))
>  #define btread(adr)         bmtread(bt->bt878_mem+(adr))
>  
>  #define btand(dat,adr)      btwrite((dat) & btread(adr), adr)
>  #define btor(dat,adr)       btwrite((dat) | btread(adr), adr)
>  #define btaor(dat,mask,adr) btwrite((dat) | ((mask) & btread(adr)), adr)
>  
>  #if defined(dprintk)
>  #undef dprintk
>
> -
>   

Ack'd-by: Manu Abraham <manu@linuxtv.org>


      reply	other threads:[~2006-04-09 18:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-09 17:48 [2.6 patch] dvb/bt8xx/bt878.c: don't export static variables Adrian Bunk
2006-04-09 18:41 ` Manu Abraham [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4439554E.4050200@gmail.com \
    --to=abraham.manu@gmail.com \
    --cc=bunk@stusta.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=v4l-dvb-maintainer@linuxtv.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.