From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Rolf Eike Beer <eike-kernel@sf-tec.de>
Cc: Denis Vlasenko <vda@ilport.com.ua>,
SCSI List <linux-scsi@vger.kernel.org>,
linux-kernel@vger.kernel.org, gibbs@scsiguy.com
Subject: Re: [PATCH] deinline some functions in aic7xxx drivers, save 80k of text
Date: Mon, 10 Apr 2006 11:40:21 +0200 [thread overview]
Message-ID: <443A2805.6000806@s5r6.in-berlin.de> (raw)
In-Reply-To: <200604100919.23244.eike-kernel@sf-tec.de>
Rolf Eike Beer wrote:
> Denis Vlasenko wrote:
>> I am leaving it up to maintainer to decide. After all, the driver
>> is for multiple OSes, other OS may lack mdelay().
>
> The comment says about multiple milliseconds sleeps which just don't happen.
Given what ah{c,d}_delay are (OS dependent wrappers) and how they are
used (definitely not for multi-msec delays), they should just be changed
into a #define ah{c,d}_delay(us) udelay(us) or into void inline
ah{c,d}_delay(long us) {udelay(us);}.
--
Stefan Richter
-=====-=-==- -=-- -=-=-
http://arcgraph.de/sr/
next prev parent reply other threads:[~2006-04-10 9:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-10 5:44 [PATCH] deinline some functions in aic7xxx drivers, save 80k of text Denis Vlasenko
2006-04-10 5:46 ` Denis Vlasenko
2006-04-10 5:49 ` Denis Vlasenko
[not found] ` <200604100903.35431.eike-kernel@sf-tec.de>
[not found] ` <200604101015.36869.vda@ilport.com.ua>
2006-04-10 7:19 ` Rolf Eike Beer
2006-04-10 7:54 ` Denis Vlasenko
2006-04-10 9:40 ` Stefan Richter [this message]
2006-04-10 10:00 ` Hannes Reinecke
2006-04-10 10:00 ` Hannes Reinecke
2006-04-10 10:16 ` Stefan Richter
2006-04-10 16:20 ` Arjan van de Ven
2006-04-10 8:43 ` Stefan Richter
2006-04-10 8:56 ` Denis Vlasenko
2006-04-10 10:19 ` Stefan Richter
2006-04-10 14:22 ` Justin T. Gibbs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=443A2805.6000806@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=eike-kernel@sf-tec.de \
--cc=gibbs@scsiguy.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=vda@ilport.com.ua \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.