From: Jeff Garzik <jeff@garzik.org>
To: Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-ide@vger.kernel.org
Subject: Re: [git patch] libata scsi eh fixed to use transport class
Date: Mon, 10 Apr 2006 14:58:45 -0400 [thread overview]
Message-ID: <443AAAE5.2020208@garzik.org> (raw)
In-Reply-To: <20060410185039.GA32027@havoc.gtf.org>
[-- Attachment #1: Type: text/plain, Size: 676 bytes --]
Jeff Garzik wrote:
> diff --git a/drivers/scsi/sata_mv.c b/drivers/scsi/sata_mv.c
> index fa901fd..0ebf136 100644
> --- a/drivers/scsi/sata_mv.c
> +++ b/drivers/scsi/sata_mv.c
> @@ -378,8 +378,6 @@ static struct scsi_host_template mv_sht
> .name = DRV_NAME,
> .ioctl = ata_scsi_ioctl,
> .queuecommand = ata_scsi_queuecmd,
> - .eh_strategy_handler = ata_scsi_error,
> - .can_queue = MV_USE_Q_DEPTH,
> .this_id = ATA_SHT_THIS_ID,
> .sg_tablesize = MV_MAX_SG_CT / 2,
> .cmd_per_lun = ATA_SHT_CMD_PER_LUN,
And the obvious patch (attached) was just checked in, to fix the above
deletion that was in Christoph's original patch, subsequently merged.
Jeff
[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 685 bytes --]
commit 1b72373491a061be6d456d219a4e2d054ac2aaad
Author: Jeff Garzik <jeff@garzik.org>
Date: Mon Apr 10 14:56:39 2006 -0400
[libata] sata_mv: fix can_queue line accidentally removed in scsi-eh patch
1b72373491a061be6d456d219a4e2d054ac2aaad
diff --git a/drivers/scsi/sata_mv.c b/drivers/scsi/sata_mv.c
index 0ebf136..b64b077 100644
--- a/drivers/scsi/sata_mv.c
+++ b/drivers/scsi/sata_mv.c
@@ -378,6 +378,7 @@ static struct scsi_host_template mv_sht
.name = DRV_NAME,
.ioctl = ata_scsi_ioctl,
.queuecommand = ata_scsi_queuecmd,
+ .can_queue = MV_USE_Q_DEPTH,
.this_id = ATA_SHT_THIS_ID,
.sg_tablesize = MV_MAX_SG_CT / 2,
.cmd_per_lun = ATA_SHT_CMD_PER_LUN,
prev parent reply other threads:[~2006-04-10 18:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-10 18:50 [git patch] libata scsi eh fixed to use transport class Jeff Garzik
2006-04-10 18:58 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=443AAAE5.2020208@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@osdl.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.