Re: Re: [Xen-changelog] If the 'cdrom=' option is specified in the definition file but media is

[Anthony Liguori <aliguori@us.ibm.com>]

Ewan Mellor wrote:
> On Mon, Apr 10, 2006 at 01:29:13PM -0500, Anthony Liguori wrote:
>  
>   
>> Doesn't this need a Signed-off-by: Ross Maxfield <rmaxfiel@novell.com>?
>>     
>
> People have been complaining that a patch should not retain the Signed-off-by
> line if the patch has been modified, because they do not sign-off the modified
> patch.  If a patch needs minor changes before it can be committed, we can
> either bounce it back to the author, which seems unnecessarily heavyweight, or
> do what Keir's done here, and sign-off the patch himself.  The From: line
> retains the audit trail, credit, and copyright, and it's clear that Keir
> himself thinks that this patch is acceptable.
>   

I won't speak for Hollis (although I will CC him :-)) but my 
understanding is that the appropriate thing to do is check in the patch 
with the original Signed-off-by and then check in another patch on top 
of that with the necessary changes (this time, with just Keir's 
Signed-off-by).

I think the intention is that the original submitter needs to have a 
Signed-off-by to signify that the origin of the code is kosher (which is 
something Keir cannot do on his own if the code didn't originate from 
him).  Is this how other people understand it?

Regards,

Anthony Liguori

> Ewan.
>