[PATCH] kdump-ppc64-xmon-stop-cpu

[PATCH] kdump-ppc64-xmon-stop-cpu

[David Wilder]

[-- Attachment #1: Type: text/plain, Size: 493 bytes --]

Patch 3 of 3

- During CPU(s) hang scenarios, kdump could not stop these CPUs. 
However, the user could invoke soft-reset to shoot down CPUs reliably. 
But, when the debugger is enabled, these CPUs are returned to hang state 
after they exited from the debugger. This patch fixes this issue by 
calling crash_kexec_secondary() before returns to previous state.

Please pick up this patch.

-- 
David Wilder
IBM Linux Technology Center
Beaverton, Oregon, USA 
dwilder@us.ibm.com
(503)578-3789


[-- Attachment #2: kdump-ppc64-xmon-stop-cpu.patch --]
[-- Type: text/x-patch, Size: 1273 bytes --]


- During CPU(s) hang scenarios, kdump could not stop these CPUs. However, the user could invoke soft-reset to shoot down CPUs reliably. But, when the debugger is enabled, these CPUs are returned to hang state after they exited from the debugger. This patch fixes this issue by calling crash_kexec_secondary() before returns to previous state.

Signed-off-by: David Wilder <dwilder@us.ibm.com>
Signed-off-by: Haren Myneni <haren@us.ibm.com>

--- 2617-rc1/arch/powerpc/kernel/traps.c.orig	2006-04-05 13:25:22.000000000 -0700
+++ 2617-rc1/arch/powerpc/kernel/traps.c	2006-04-05 13:25:33.000000000 -0700
@@ -206,6 +206,16 @@ void system_reset_exception(struct pt_re
 
 	die("System Reset", regs, SIGABRT);
 
+	/*
+	 * Some CPUs which got released from debugger will execute this path.
+	 * These CPUs entered debugger first time via soft-reset - Means,
+	 * could be possible that these CPUs may not repond to an IPI later.
+	 * Therefore, has to call kdump func directly.
+	 * Not a problem if we exited from debugger to recover. In this case
+	 * there will not be any primary kexec CPU. Hence, will be returned.
+	 */
+	crash_kexec_secondary(regs);
+
 	/* Must die if the interrupt is not recoverable */
 	if (!(regs->msr & MSR_RI))
 		panic("Unrecoverable System Reset");

Re: [PATCH] kdump-ppc64-xmon-stop-cpu

[Paul Mackerras]

David Wilder writes:

> - During CPU(s) hang scenarios, kdump could not stop these CPUs. 
> However, the user could invoke soft-reset to shoot down CPUs reliably. 
> But, when the debugger is enabled, these CPUs are returned to hang state 
> after they exited from the debugger. This patch fixes this issue by 
> calling crash_kexec_secondary() before returns to previous state.

All three of your patches need a good 1-line description in the
subject and better description - one which is comprehensible to
someone who doesn't know all the internals of kdump, and with correct
English grammar.  I had to read this one about 4 times before I got
much of an idea what it was supposed to be about.  Please resubmit all
three patches in your series.

Paul.