Re: Re: [Xen-changelog] If the 'cdrom=' option is specified in the definition file but media is

[Anthony Liguori <aliguori@us.ibm.com>]

Ewan Mellor wrote:
> On Mon, Apr 10, 2006 at 01:29:13PM -0500, Anthony Liguori wrote:
>
>   
>> Xen patchbot -3.0-testing wrote:
>>     
>>> # HG changeset patch
>>> # User kaf24@firebug.cl.cam.ac.uk
>>> # Node ID fd526926e0d1c0671295aa7f4b952186c9345173
>>> # Parent  408f51a850f47af4db20f43f281935909d502511
>>> If the 'cdrom=' option is specified in the definition file but media is 
>>> not found in the CD drive then main() in vl.c exits and the guest appears 
>>> to hang.  This patch modifies vl.c slightly to check for the presents of 
>>> media.  If the cdrom cannot be opened then the cd entry is removed from 
>>> hd_filename[] and bs_table[] allowing the guest to continue initializing. 
>>> If the guest requires the CD media then the guest should report, gracefully
>>> or otherwise, that it's missing.
>>>
>>> From: Ross Maxfield <rmaxfiel@novell.com>
>>>
>>> Signed-off-by: Keir Fraser <keir@xensource.com>
>>>  
>>>       
>> Doesn't this need a Signed-off-by: Ross Maxfield <rmaxfiel@novell.com>?
>>     
>
> People have been complaining that a patch should not retain the Signed-off-by
> line if the patch has been modified, because they do not sign-off the modified
> patch.  If a patch needs minor changes before it can be committed, we can
> either bounce it back to the author, which seems unnecessarily heavyweight, or
> do what Keir's done here, and sign-off the patch himself.  The From: line
> retains the audit trail, credit, and copyright, and it's clear that Keir
> himself thinks that this patch is acceptable.
>   

Just so this doesn't get lost in the discussion,  I meant to say that I 
was referring to the original submission.  The original patch submission 
did not contain a Signed-off-by line.

Regardless of the interpretation of the DCO, Ross should resubmit the 
patch with a Signed-off-by.

Regards,

Anthony Liguori

> Ewan.
>